[extension/healthcheckv2] Add skeleton #32523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwear
force-pushed
the
healthcheck-v2-skeleton
branch
2 times, most recently
from
dcdf7c6
to
9a2593a
Compare
mwear
force-pushed
the
healthcheck-v2-skeleton
branch
from
9a2593a
to
7e15ca4
Compare
mwear
force-pushed
the
healthcheck-v2-skeleton
branch
from
7e15ca4
to
0403352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is an attempt to decompose #30673 into more manageable pieces for review. It introduces the skeleton and config for the new healthcheck extension. The extension itself is implemented as multiple subcomponents. That is, the http and grpc services implement the component interface individually, as does the extension that ties them together. I mention this because this PR introduces the config structs and this is relevant for understanding why it is organized as it is. Additionally, the extension supports and defaults to the config for the existing extension. This is so it can be a drop in replacement for the existing extension with an easy migration path to the new functionality and features introduced the v2 extension. See the parent PR to understand how the pieces fit together.
Link to tracking Issue: #26661
Testing: Units / manual
Documentation: Readme, etc.