[chore] update deprecated configtls functions #32332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
atoulme,
fatsheep9146,
dmitryax,
MovieStoreGuy,
evan-bradley,
tigrannajaryan,
jpkrohling,
andrzej-stencel,
crobert-1 and
Aneurysm9
as code owners
github-actions
bot
added
cmd/opampsupervisor
exporter/elasticsearch
exporter/prometheus
exporter/signalfx
exporter/syslog
extension/oauth2clientauth
extension/opamp
internal/kafka
pkg/stanza
processor/resourcedetection
github-actions
bot
requested review from
antonblock,
dashpole,
dehaansa,
hughesjj,
JaredTan95,
kasia-kujawa,
mcardy,
pavankrish123,
pavolloffay,
portertech,
rnishtala-sumo,
schmikei and
ycombinator
rnishtala-sumo
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
LGTM! Looks like this is related to this change in core:
open-telemetry/opentelemetry-collector#9813
dmitryax
approved these changes
Apr 12, 2024
jpkrohling
pushed a commit
that referenced
this pull request
May 16, 2024
**Description:** Drop duplicate testing of parts related to TLS settings which already verified more extensively in other tests. This led to relevant changes requiring identical modifications in multiple places (e.g., #32332, #32394). Also remove 'TokenURL' and 'Scopes' from the corresponding configs as they are not required anymore (since #30469). For more details, see also #32623 (comment) Signed-off-by: Ilias Katsakioris <ilias.katsakioris@hpe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.