-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton for new rabbitmq exporter component #31800
Merged
djaglowski
merged 8 commits into
open-telemetry:main
from
swar8080:rabbitmq-exporter-skeleton
Mar 26, 2024
Merged
Add skeleton for new rabbitmq exporter component #31800
djaglowski
merged 8 commits into
open-telemetry:main
from
swar8080:rabbitmq-exporter-skeleton
Mar 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
reviewed
Mar 18, 2024
Very close. Just need to add a line to |
swar8080
force-pushed
the
rabbitmq-exporter-skeleton
branch
from
March 19, 2024 00:16
b5e8114
to
4578b37
Compare
swar8080
commented
Mar 19, 2024
atoulme
reviewed
Mar 20, 2024
atoulme
reviewed
Mar 20, 2024
atoulme
approved these changes
Mar 20, 2024
atoulme
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Mar 21, 2024
Got the pipeline to pass - thanks @atoulme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Accepted Component
New component has been sponsored
ready to merge
Code review completed; ready to merge by maintainers
reports/distributions/contrib.yaml
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Sets-up the configuration format and common component boilerplate for the rabbitmq exporter
Implementation will be in other pull requests
Link to tracking Issue: 28891
Testing: Standard initial unit tests
Documentation: Created README for the component