Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/datadog] Remove feature gate connector.datadogconnector.performance #31638

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Mar 7, 2024

No description provided.

@songy23 songy23 marked this pull request as ready for review March 7, 2024 14:58
@songy23 songy23 requested a review from a team March 7, 2024 14:58
@djaglowski djaglowski merged commit 26853f1 into open-telemetry:main Mar 7, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 7, 2024
@songy23 songy23 deleted the remove-fg branch March 7, 2024 15:56
@djaglowski
Copy link
Member

@songy23, this appears to have broken windows tests: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/8190945099

Should we revert or do you think it's a quick fix?

@songy23
Copy link
Member Author

songy23 commented Mar 7, 2024

That's surprising as this feature gate is no longer used anywhere now.

We can revert for now, I'll take a look at the test failure

@djaglowski
Copy link
Member

Hmm, might be unrelated. I didn't look into it much, just saw it was a failure in the same component.

djaglowski pushed a commit that referenced this pull request Mar 7, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
@songy23 songy23 restored the remove-fg branch March 14, 2024 21:00
mx-psi added a commit that referenced this pull request Mar 15, 2024
…rformance (#31770)

This restores
#31638.


#31638
was reverted initially because we thought it led to
#31663,
but it turns out
#31663
is still happening without
#31638
so it is probably a different issue. It should be safe to roll forward
#31638.

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants