-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Delete otelcontribcol code #30902
Conversation
e4a16d4
to
4b2b3cd
Compare
4b2b3cd
to
5709d52
Compare
Did we move all the lifecycle tests to the components? |
No, we still miss some, here is the list:
FWIW I updated #27849 to reflect this list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be blocked on the lifecycle changes?
Yes and no ; it can be debated in a SIG meeting. Right now the current tests bail when the creation of the component fails, and the new tests are less forgiving. So our test coverage is actually probably already better with the new generated tests. That said, we don't have them done everywhere. |
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
b60e26f
to
fcbf26c
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
fcbf26c
to
837b721
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Description:
Deletes the code under
cmd/otelcontribcol
, move to build it undercmd/otelcontribcol/_build
without checking it in.Link to tracking Issue:
Fixes #30884