[extension/basicauth] Accept empty usernames ; remove extra validation code #30470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
basicauth_validation
branch
from
87b01c5
to
5a190f9
Compare
frzifus
approved these changes
Jan 12, 2024
dmitryax
reviewed
Jan 12, 2024
atoulme
force-pushed
the
basicauth_validation
branch
from
5a190f9
to
455a1c2
Compare
atoulme
changed the title
dmitryax
approved these changes
Jan 12, 2024
|
@dmitryax ready to merge? |
jpkrohling
approved these changes
Jan 25, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…n code (open-telemetry#30470) **Description:** Drop the validation that username is a required non-empty string. Remove extraneous validation logic, use config.Validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Drop the validation that username is a required non-empty string.
Remove extraneous validation logic, use config.Validate