Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] address linting issues in generated tests #30452

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[chore] address linting issues in generated tests #30452

merged 1 commit into from
Jan 11, 2024

Conversation

codeboten
Copy link
Contributor

This addresses the following lint failure:

var-naming: don't use underscores in Go names; func Test_ComponentLifecycle should be TestComponentLifecycle (revive)
func Test_ComponentLifecycle(t *testing.T) {

[chore] address linting issues in generated tests
762b9b3 
This addresses the following lint failure:

```
var-naming: don't use underscores in Go names; func Test_ComponentLifecycle should be TestComponentLifecycle (revive)
func Test_ComponentLifecycle(t *testing.T) {
```

Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten requested a review from a team January 11, 2024 21:28
@dmitryax
Copy link
Member

Is there a way to enable this linter for generated files?

@codeboten
Copy link
Contributor Author

Is there a way to enable this linter for generated files?

I'm looking at this, not sure yet though

@codeboten codeboten merged commit 5caa803 into open-telemetry:main Jan 11, 2024
78 of 79 checks passed
@codeboten codeboten deleted the codeboten/address-linting-issues branch January 11, 2024 21:48
@github-actions github-actions bot added this to the next release milestone Jan 11, 2024
@codeboten codeboten mentioned this pull request Jan 11, 2024
Merged
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
@cparkins
[chore] address linting issues in generated tests (open-telemetry#30452)
8f9c537 
This addresses the following lint failure:

```
var-naming: don't use underscores in Go names; func Test_ComponentLifecycle should be TestComponentLifecycle (revive)
func Test_ComponentLifecycle(t *testing.T) {
```

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@MovieStoreGuy MovieStoreGuy Awaiting requested review from MovieStoreGuy MovieStoreGuy is a code owner

@andrzej-stencel andrzej-stencel Awaiting requested review from andrzej-stencel andrzej-stencel is a code owner

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@fatsheep9146 fatsheep9146 Awaiting requested review from fatsheep9146 fatsheep9146 is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner

@yurishkuro yurishkuro Awaiting requested review from yurishkuro yurishkuro is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley is a code owner

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@bryan-aguilar bryan-aguilar

Labels
cmd/mdatagen mdatagen command exporter/alertmanager exporter/alibabacloudlogservice Alibaba components exporter/awss3 exporter/signalfx exporter/splunkhec extension/bearertokenauth extension/headerssetter extension/healthcheck Health Check Extension extension/opamp extension/pprof extension/remotetap extension/sigv4auth processor/attributes Attributes processor processor/cumulativetodelta Cumulative To Delta processor processor/datadog processor/deltatorate Delta To Rate processor processor/filter Filter processor processor/groupbyattrs Group By Attributes processor processor/groupbytrace Group By Trace processor processor/k8sattributes k8s Attributes processor processor/logstransform Logs Transform processor processor/metricsgeneration Metrics Generation processor processor/metricstransform Metrics Transform processor processor/probabilisticsampler Probabilistic Sampler processor processor/redaction Redaction processor processor/remotetap processor/resource Resource processor processor/resourcedetection Resource detection processor processor/routing Routing processor processor/schema Schema processor processor/servicegraph Service graph processor processor/span processor/spanmetrics Span Metrics processor processor/sumologic processor/tailsampling Tail sampling processor processor/transform Transform processor receiver/aerospike receiver/apache receiver/apachespark receiver/awscloudwatch receiver/awscloudwatchmetrics receiver/awscontainerinsight receiver/awsfirehose receiver/azureblob receiver/azureeventhub receiver/azuremonitor receiver/bigip receiver/carbon receiver/cloudflare receiver/cloudfoundry receiver/collectd receiver/couchdb receiver/expvar receiver/filestats receiver/flinkmetrics receiver/fluentforward receiver/googlecloudpubsub receiver/googlecloudspanner receiver/haproxy receiver/hostmetrics receiver/httpcheck HTTP Check receiver receiver/influxdb receiver/jaeger receiver/k8sevents receiver/kafka receiver/kafkametrics receiver/mysql receiver/nginx receiver/nsxt NSXT Receiver receiver/opencensus receiver/oracledb receiver/otlpjsonfile receiver/podman receiver/postgresql receiver/prometheus Prometheus receiver receiver/pulsar receiver/purefa receiver/purefb receiver/rabbitmq receiver/redis Redis related issues receiver/riak receiver/sapm receiver/signalfx receiver/simpleprometheus receiver/skywalking receiver/snmp receiver/snowflake Snowflake receiver receiver/splunkenterprise receiver/splunkhec receiver/sqlquery SQL query receiver receiver/sshcheck receiver/statsd statsd related issues receiver/syslog receiver/tcplog receiver/udplog receiver/vcenter
Projects
None yet
Milestone
v0.93.0
Development

Successfully merging this pull request may close these issues.
3 participants
@codeboten @dmitryax @bryan-aguilar