Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/stanza] Consolidate attribute code into single package #30449

Conversation

djaglowski
Copy link
Member

This change simplifies the reader package by pulling all file resolution logic into a single package. It also moves related config and attribute name constants into the same package.

@djaglowski djaglowski force-pushed the pkg-stanza-reader-attributes-refactor branch from 72332fa to 74657df Compare January 11, 2024 20:35
@djaglowski djaglowski force-pushed the pkg-stanza-reader-attributes-refactor branch 3 times, most recently from 8090305 to 9667984 Compare January 12, 2024 16:52
@github-actions github-actions bot requested a review from atoulme January 12, 2024 16:53
@djaglowski djaglowski marked this pull request as ready for review January 12, 2024 17:15
@djaglowski djaglowski requested a review from a team January 12, 2024 17:15
@djaglowski djaglowski merged commit ad6a16c into open-telemetry:main Jan 17, 2024
85 checks passed
@djaglowski djaglowski deleted the pkg-stanza-reader-attributes-refactor branch January 17, 2024 14:45
@github-actions github-actions bot added this to the next release milestone Jan 17, 2024
codeboten pushed a commit that referenced this pull request Jan 17, 2024
mfyuce pushed a commit to mfyuce/opentelemetry-collector-contrib that referenced this pull request Jan 18, 2024
…emetry#30449)

This change simplifies the reader package by pulling all file resolution
logic into a single package. It also moves related config and attribute
name constants into the same package.
mfyuce pushed a commit to mfyuce/opentelemetry-collector-contrib that referenced this pull request Jan 18, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
…emetry#30449)

This change simplifies the reader package by pulling all file resolution
logic into a single package. It also moves related config and attribute
name constants into the same package.
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants