-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/servicegraph] update own telemetry to use otel #29917
[processor/servicegraph] update own telemetry to use otel #29917
Conversation
This updates the servicegraph processor to emit telemetry using OpenTelemetry instead of OpenCensus. Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
5e52cdd
to
2931b34
Compare
scopeName := "processor/servicegraphprocessor" | ||
meter := set.MeterProvider.Meter(scopeName) | ||
|
||
droppedSpan, _ := meter.Int64Counter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: Since I see we started to use "metadata" yaml at leas for the type. Can we have in there a "component metrics" section (similar but different than the "scraper metrics" we already have) than essentially generate a function where we can pass a "MeterProvider" and creates all instruments and simplifies this boilerplate?
Kind of an "obsreport" per component custom generated via the metadata yaml?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bogdandrutu yeah that would be useful.... gets rid of the scope naming question as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dmitryax since you are the most knowledgeable person about metadata gen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this idea. Otherwise we have more docs on those metrics to manage elsewhere.
…etry#29917) This updates the servicegraph processor to emit telemetry using OpenTelemetry instead of OpenCensus. Related open-telemetry#29867 --------- Signed-off-by: Alex Boten <aboten@lightstep.com>
This updates the servicegraph processor to emit telemetry using OpenTelemetry instead of OpenCensus.
Related #29867