Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/servicegraph] update own telemetry to use otel #29917

Merged

Conversation

codeboten
Copy link
Contributor

This updates the servicegraph processor to emit telemetry using OpenTelemetry instead of OpenCensus.

Related #29867

@codeboten codeboten requested a review from a team December 15, 2023 16:41
@codeboten codeboten mentioned this pull request Dec 15, 2023
16 tasks
@github-actions github-actions bot added the processor/servicegraph Service graph processor label Dec 15, 2023
Alex Boten added 2 commits December 15, 2023 09:06
This updates the servicegraph processor to emit telemetry using OpenTelemetry instead of OpenCensus.

Signed-off-by: Alex Boten <aboten@lightstep.com>
Signed-off-by: Alex Boten <aboten@lightstep.com>
@codeboten codeboten force-pushed the codeboten/rm-census-servicegraph branch from 5e52cdd to 2931b34 Compare December 15, 2023 17:55
scopeName := "processor/servicegraphprocessor"
meter := set.MeterProvider.Meter(scopeName)

droppedSpan, _ := meter.Int64Counter(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea: Since I see we started to use "metadata" yaml at leas for the type. Can we have in there a "component metrics" section (similar but different than the "scraper metrics" we already have) than essentially generate a function where we can pass a "MeterProvider" and creates all instruments and simplifies this boilerplate?

Kind of an "obsreport" per component custom generated via the metadata yaml?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogdandrutu yeah that would be useful.... gets rid of the scope naming question as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitryax since you are the most knowledgeable person about metadata gen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea. Otherwise we have more docs on those metrics to manage elsewhere.

@bogdandrutu bogdandrutu merged commit 9378ab5 into open-telemetry:main Dec 15, 2023
85 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 15, 2023
@codeboten codeboten deleted the codeboten/rm-census-servicegraph branch December 15, 2023 22:01
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jan 10, 2024
…etry#29917)

This updates the servicegraph processor to emit telemetry using
OpenTelemetry instead of OpenCensus.

Related open-telemetry#29867

---------

Signed-off-by: Alex Boten <aboten@lightstep.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/servicegraph Service graph processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants