Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Added Jeremy Hicks (greatestusername) to codeowner list #29450

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

shalper2
Copy link
Contributor

Description: Added user Jeremy Hicks (@greatestusername) to codeowner list

Link to tracking Issue: none

Testing: none

Documentation: Updated documentation and ran mdatagen to update relevant files. Some newlines were added by mdatagen.

@codeboten codeboten added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 22, 2023
@crobert-1
Copy link
Member

@greatestusername Can you approve here too?

@atoulme
Copy link
Contributor

atoulme commented Nov 22, 2023

you also need to add the codeowner to .github/CODEOWNERS.

@atoulme
Copy link
Contributor

atoulme commented Nov 22, 2023

@crobert-1
Copy link
Member

you also need to add the codeowner to .github/CODEOWNERS.

This can be done with make gengithub, right?

@atoulme
Copy link
Contributor

atoulme commented Nov 23, 2023

you also need to add the codeowner to .github/CODEOWNERS.

This can be done with make gengithub, right?

you also need to set a github token. I might bring back the members cache rather than having github API called every time.

@greatestusername
Copy link
Contributor

also we need to add @greatestusername to the OpenTelemetry membership. @greatestusername please go ahead and open this request: https://github.com/open-telemetry/community/issues/new?assignees=&labels=area%2Fgithub-membership&projects=&template=membership.md&title=REQUEST%3A+New+membership+for+%3Cyour-GH-handle%3E

open-telemetry/community#1819
Let me know if there is anything else you need me to do.

Thanks!!

@greatestusername
Copy link
Contributor

I am now a member and make gengithub should work now I think?
Thanks all!!!

@shalper2
Copy link
Contributor Author

shalper2 commented Dec 1, 2023

@greatestusername has been added to the codeowners list hooray

@atoulme
Copy link
Contributor

atoulme commented Dec 1, 2023

just run make generate at the root to get the README regenerated too...

@atoulme
Copy link
Contributor

atoulme commented Dec 7, 2023

@MovieStoreGuy please do the honors?

@MovieStoreGuy MovieStoreGuy merged commit 01927d4 into open-telemetry:main Dec 7, 2023
83 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 7, 2023
jayasai470 pushed a commit to jayasai470/opentelemetry-collector-contrib that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/splunkenterprise Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants