[pkg/ottl] Expose condition-only parsing #29294
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/filter
pkg/ottl
connector/count
processor/filter
TylerHelmuth
force-pushed
the
ottl-condition-parser
branch
2 times, most recently
from
eb5b622
to
8758879
Compare
TylerHelmuth
force-pushed
the
ottl-condition-parser
branch
2 times, most recently
from
21376d7
to
45e3ad0
Compare
TylerHelmuth
added a commit
that referenced
this pull request
Nov 17, 2023
**Description:** This PR adds a new public API to support parsing and using conditions. This implementation opted to add ParseConditions directly to the existing Parser instead of creating a second Parser struct. Since any Parser needs the Context, Functions, PathExpressionParser, EnumParser, and telemetry settings the 2 structs would be incredibly similar. See these structs implemented in components here: #29294 **Link to tracking Issue:** <Issue number if applicable> Works towards #13545 **Testing:** <Describe what testing was performed and which tests were added.> Added tests **Documentation:** <Describe the documentation added.> Added godoc strings
TylerHelmuth
force-pushed
the
ottl-condition-parser
branch
from
45e3ad0
to
7b09b1b
Compare
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
**Description:** This PR adds a new public API to support parsing and using conditions. This implementation opted to add ParseConditions directly to the existing Parser instead of creating a second Parser struct. Since any Parser needs the Context, Functions, PathExpressionParser, EnumParser, and telemetry settings the 2 structs would be incredibly similar. See these structs implemented in components here: open-telemetry#29294 **Link to tracking Issue:** <Issue number if applicable> Works towards open-telemetry#13545 **Testing:** <Describe what testing was performed and which tests were added.> Added tests **Documentation:** <Describe the documentation added.> Added godoc strings
TylerHelmuth
added a commit
that referenced
this pull request
Nov 30, 2023
**Description:** Adds a new `ConditionSequence` struct to help handle processing a list of Conditions. The primary reason to use a `ConditionSequence` is to let the struct handle errors. Since that is its defining purpose, I opted to make `ErrorMode` a required argument in the "constructor" instead of an Option. I also update `internal/filterottl` to use this struct instead of `Statements`. This is a non-breaking change. If we like this pattern, I will do a breaking change to replace `Statements` with a similar `StatementSequence` struct in a future PR . See these structs implemented in components here: #29294 **Link to tracking Issue:** <Issue number if applicable> Related to #13545 **Testing:** Added new tests **Documentation:** <Describe the documentation added.> Added godoc comments --------- Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Documentation: