Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/kubeletstatsreceiver] address lint issues: Implicit Memory Aliasing #29113

Merged

Conversation

etiennep
Copy link
Contributor

Description: This PR fixes an implicit memory aliasing lint issue in the kubeletstatsreceiver

  • fixed code
  • removed linting exception

Link to tracking Issue: #28584

Testing: ran unit tests

Documentation: N/A

@etiennep etiennep force-pushed the etiennep.issue-28584-address-lint-issue branch from 16c6119 to 4e5f13d Compare November 12, 2023 22:24
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 13, 2023
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Nov 13, 2023
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @etiennep!

@codeboten codeboten merged commit 30a5f14 into open-telemetry:main Nov 14, 2023
90 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 14, 2023
RoryCrispin pushed a commit to ClickHouse/opentelemetry-collector-contrib that referenced this pull request Nov 24, 2023
…Aliasing (open-telemetry#29113)

This PR fixes an implicit memory aliasing lint issue in
the kubeletstatsreceiver

* fixed code
* removed linting exception

open-telemetry#28584

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/kubeletstats Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants