[chore] [exporter/azuremonitor] Incorporate SDK Version Tagging in Azure Monitor Exporter #28999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcwiese
approved these changes
Nov 7, 2023
|
@songy23 Got approval from code owner. Could you please help merge this PR? |
songy23
added
the
ready to merge
|
👋 Marked as ready to merge. A maintainer will help merge this PR (I don't have permission) |
rajkumar-rangaraj
changed the title
|
@open-telemetry/collector-contrib-approvers Could you please help merge this PR, got an approval from the code owner. |
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…ure Monitor Exporter (open-telemetry#28999) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This pull request enhances the Azure Monitor Exporter by tagging telemetry data with the OpenTelemetry Collector's internal SDK version. This additional metadata will facilitate improved monitoring, troubleshooting, and analysis of data sourced from different versions of the collector. **Changes:** - Added functionality in `azuremonitorexporter` to append the SDK version to each telemetry envelope. - Implemented `getCollectorVersion` to dynamically fetch the current version of the OpenTelemetry Collector. **Sample SDK Version String:** - The SDK version string is formatted as follows: `otelc-<version>-<os>-<arch>` - Example: `otelc-v0.88.1-lin-amd64` **Note:** - Since this change pertains to internal diagnostic data enrichment and does not modify any external behavior or configuration interfaces, it does not necessitate a changelog entry. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> - Adjusted existing unit tests to ensure the SDK version string is correctly included in the telemetry envelopes. ```json { "ver": 1, "name": "Microsoft.ApplicationInsights.RemoteDependency", "time": "2023-11-06T15:21:12.9807976-08:00", "sampleRate": 100, "seq": "", "iKey": "Ikey", "tags": { "ai.cloud.role": "otlp-test", "ai.cloud.roleInstance": "2c4a6d1b-f7cb-4579-8d05-65b83b4acf7e", *"ai.internal.sdkVersion": "otelc-v0.88.1-lin-amd64",* "ai.operation.id": "0e3a010cb64d919aa8f214bf0a166334", "ai.operation.parentId": "" }, "data": { } } ``` --------- Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request enhances the Azure Monitor Exporter by tagging telemetry data with the OpenTelemetry Collector's internal SDK version. This additional metadata will facilitate improved monitoring, troubleshooting, and analysis of data sourced from different versions of the collector.
Changes:
azuremonitorexporterto append the SDK version to each telemetry envelope.getCollectorVersionto dynamically fetch the current version of the OpenTelemetry Collector.Sample SDK Version String:
otelc-<version>-<os>-<arch>otelc-v0.88.1-lin-amd64Note:
Link to tracking Issue:
Testing:
{ "ver": 1, "name": "Microsoft.ApplicationInsights.RemoteDependency", "time": "2023-11-06T15:21:12.9807976-08:00", "sampleRate": 100, "seq": "", "iKey": "Ikey", "tags": { "ai.cloud.role": "otlp-test", "ai.cloud.roleInstance": "2c4a6d1b-f7cb-4579-8d05-65b83b4acf7e", *"ai.internal.sdkVersion": "otelc-v0.88.1-lin-amd64",* "ai.operation.id": "0e3a010cb64d919aa8f214bf0a166334", "ai.operation.parentId": "" }, "data": { } }