-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/gitproviderreceiver] add repo branch and contrib count metrics #28885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update readme documentation * update factory and config tests * update metadata and re-generate to include count metric
adrielp
commented
Nov 3, 2023
atoulme
reviewed
Nov 3, 2023
receiver/gitproviderreceiver/internal/scraper/githubscraper/helpers_test.go
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Nov 3, 2023
atoulme
reviewed
Nov 3, 2023
atoulme
reviewed
Nov 3, 2023
atoulme
reviewed
Nov 3, 2023
atoulme
reviewed
Nov 3, 2023
atoulme
reviewed
Nov 3, 2023
receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Nov 3, 2023
receiver/gitproviderreceiver/internal/scraper/githubscraper/github_scraper.go
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Nov 3, 2023
receiver/gitproviderreceiver/internal/scraper/githubscraper/helpers.go
Outdated
Show resolved
Hide resolved
atoulme
reviewed
Nov 3, 2023
receiver/gitproviderreceiver/internal/scraper/githubscraper/helpers.go
Outdated
Show resolved
Hide resolved
* adds the rest api contributor count metric * further breaks out functions * add graphql and rest testing for new functions * makes various clean ups
adrielp
commented
Nov 8, 2023
Co-authored-by: Antoine Toulme <antoine@toulme.name>
atoulme
reviewed
Nov 22, 2023
atoulme
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a question on the retract instruction
mx-psi
reviewed
Nov 22, 2023
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
andrzej-stencel
approved these changes
Nov 22, 2023
andrzej-stencel
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Nov 22, 2023
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…emetry#29080) This fixes security vulnerabilities found via govulncheck in the standard library when running against the previous patch versions of golang. While these vulnerabilities don't actually present themselves in the binary, the workflows when running govuln check fail and thus taking in the latest patches fix the issue. Testing gets caught in workflow run. Noticed the issue originally when running workflows on this pr: open-telemetry#28885
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…ics (open-telemetry#28885) **Description:** Second PR for the gitprovider receiver to add functionality for repo, branch, and contributor count metrics. There will have to be more than 4 repos given the amount of metrics collected in this scraper, so we're only adding these 3 to show capability and foundation. open-telemetry#22028 **Testing:** Basic tests included for the functionality. **Documentation:** Documentation updated to include information about configuration of metrics and the metrics that are currently available alongside targets. --------- Co-authored-by: Antoine Toulme <antoine@toulme.name> Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
internal/tools
ready to merge
Code review completed; ready to merge by maintainers
receiver/gitprovider
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Second PR for the gitprovider receiver to add functionality for repo, branch, and contributor count metrics. There will have to be more than 4 repos given the amount of metrics collected in this scraper, so we're only adding these 3 to show capability and foundation.
#22028
Testing:
Basic tests included for the functionality.
Documentation:
Documentation updated to include information about configuration of metrics and the metrics that are currently available alongside targets.