[exporter/clickhouseexporter]: persistent queue support #28579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredthomsen
force-pushed
the
clickhouseExporterPersistentQueueEnforced
branch
4 times, most recently
from
d46061f
to
e2f181d
Compare
songy23
approved these changes
Oct 25, 2023
fredthomsen
force-pushed
the
clickhouseExporterPersistentQueueEnforced
branch
from
e2f181d
to
3861989
Compare
dmitryax
reviewed
Oct 26, 2023
|
@hanjm, @Frapschen, PTAL. Would there be any problem if users configure multiple consumers? If so, we should document it. |
fredthomsen
force-pushed
the
clickhouseExporterPersistentQueueEnforced
branch
from
3861989
to
da1294b
Compare
dmitryax
reviewed
Oct 26, 2023
fredthomsen
force-pushed
the
clickhouseExporterPersistentQueueEnforced
branch
from
da1294b
to
f0bd0bf
Compare
dmitryax
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
LGTM but I would like codeowners, @hanjm and @Frapschen, to take a look before merging
hanjm
approved these changes
Oct 29, 2023
FWIW. I have been running the clickhouseexporter with a custom patch pretty much identical to the patch implemented here. With one difference, I also removed the single consumer limit and ran with the default from the exporterhelper (10 consumers??), resulting in significant increase in overall pipeline throughput capacity. Thanks @fredthomsen for creating this PR! |
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…8579) Addresses open-telemetry#27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…8579) Addresses open-telemetry#27653. **Description:** Added persistent storage queue support by leveraging default `exporthelper.QueueSettings` config structure. **NOTE** This does end up being a **breaking** change to the API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #27653.
Description:
Added persistent storage queue support by leveraging default
exporthelper.QueueSettingsconfig structure.NOTE This does end up being a breaking change to the API.
Link to tracking Issue:
#27653
Testing:
Adjust existing unit test.