-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[extension/encodingextension] Introduce OTLP encoding extension #27875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dao-jun
changed the title
[extension/encoding]Introduce OTLP encoding extension
[extension/encodingextension] Introduce OTLP encoding extension
Oct 20, 2023
@MovieStoreGuy All the CI checks passed, could you please help review this PR? |
VihasMakwana
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @atoulme @MovieStoreGuy can you please take a look here?
atoulme
approved these changes
Oct 22, 2023
# Conflicts: # .github/CODEOWNERS # versions.yaml
@dao-jun can you please add some basic test coverage? |
# Conflicts: # .github/dependabot.yml
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…-telemetry#27875) Introduce OTLP encoding extension. For more context, see open-telemetry#27564
RoryCrispin
pushed a commit
to ClickHouse/opentelemetry-collector-contrib
that referenced
this pull request
Nov 24, 2023
…-telemetry#27875) Introduce OTLP encoding extension. For more context, see open-telemetry#27564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Introduce OTLP encoding extension.
For more context, see #27564
Link to tracking Issue:
#28686
Testing:
Unit tests.
Documentation: