[exporter/syslog]: fix default behaviour (disable tls and use proper defaults) #27424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumo-drosiek
force-pushed
the
drosiek-syslog-defaults
branch
from
ed96c13
to
e810757
Compare
sumo-drosiek
commented
Oct 5, 2023
sumo-drosiek
force-pushed
the
drosiek-syslog-defaults
branch
from
cf9e4e5
to
9dcfbb1
Compare
added 6 commits
October 5, 2023 10:55
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-syslog-defaults
branch
from
9dcfbb1
to
dc90d91
Compare
sumo-drosiek
commented
Oct 5, 2023
andrzej-stencel
approved these changes
Oct 5, 2023
djaglowski
approved these changes
Oct 5, 2023
jmsnll
pushed a commit
to jmsnll/opentelemetry-collector-contrib
that referenced
this pull request
Nov 12, 2023
…defaults) (open-telemetry#27424) **Description:** - fix defaults - fix some typos - correctly handle data structures which are output of syslog receiver - allow to not use tls and disable it by default **Link to tracking Issue:** open-telemetry#25114 **Testing:** Unit tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: #25114
Testing:
Unit tests
Documentation:
N/A