chore(k8sclusterreceiver): 🔥 remove deprecated kubernetes API resources #26516

prashant-shahi · 2023-09-07T18:11:33Z

Description:
Remove support for deprecated Kubernetes API resources:

batch/v1beta1
autoscaling/v2beta2

This also resolves the issue with double reporting metrics for hpa and cronjob in certain k8s versions.

Link to tracking Issue(s):
#23612 #26551

Testing:
From source, built the custom image coolboi567/otelcontribcol:0.83.1 and tested in kubernetes cluster v1.25 as well as v1.27.

In K8s v1.25, we no longer see the warnings in the logs about usage of deprecated APIs.

Documentation:
N/A

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

linux-foundation-easycla · 2023-09-07T18:11:41Z

The committers listed above are authorized under a signed CLA.

✅ login: prashant-shahi / name: Prashant Shahi (c74fc14, 0f7bd1f, 6c2e5cb, 1389666, e1d1ae6, 1528480, c1e5f70, d421469, 00ebf82, 97e1d40, a6622b2, 3eca59a, ee9e5d7, 7a9bea3, fb9a091, b8e0fbb, 8ace748)
✅ login: dmitryax / name: Dmitrii Anoshin (fb9a091, b8e0fbb)

dmitryax

@prashant-shahi thank you for the PR. Can you please add a changelog entry?

receiver/k8sclusterreceiver/README.md

jinja2 · 2023-09-08T00:57:37Z

Can we drop support for the hpa and cronjob beta apis? I am not sure if we have a compatibility matrix with k8s versions. Hpa was promoted to stable in v1.23 and cronjob in v1.21. Upstream k8s currently maintains 1.25 to 1.28.

Below are EOL dates for the major managed clusters, all of which have no support for 1.22 (the last version which would need the hpa beta):

https://endoflife.date/google-kubernetes-engine
https://endoflife.date/azure-kubernetes-service
https://endoflife.date/amazon-eks

I think if we can commit to some k8s version compatibility window, it would make maintenance of k8s receivers simpler. A good place to start might be to keep up with the major managed cluster providers.

dmitryax · 2023-09-08T03:40:37Z

@jinja2, that makes sense. It depends on the definition of "support" from the collector side. Should we support collecting metrics from the deprecated resource versions? I believe we should. In that case, dropping them now makes the supported window pretty narrow: 1.28, 1.27, 1.26 due to HPA beta removal in 1.26. I'm in favor of introducing this config option to provide a smoother transition. This will likely be needed going forward as well.

…rces Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

prashant-shahi · 2023-09-08T14:11:47Z

Can you please add a changelog entry?

Changelog has been updated.

dropping them now makes the supported window pretty narrow: 1.28, 1.27, 1.26 due to HPA beta removal in 1.26. I'm in favor of introducing this config option to provide a smoother transition.

Absolutely. Introducing this option can also help the folks who do not want to upgrade to newest K8s version but want to get rid of the deprecation warning.

Also, the usage of the deprecated K8s API causes the failure of managed clusters to auto-upgrade to newer k8s version (as reported in GKE and OpenShift). The ignore_deprecated_resources option helps in that case.

jinja2 · 2023-09-08T20:40:58Z

I have started a new issue which provides more context on api versioning in k8s. The tldr is that we can use the v2 api for hpas which we created in the v2beta2 version format, starting from k8s v1.23. I don't think we should add this flag. Instead we should decide on our k8s version compatibility. Removing v2beta2 here still makes us compatible with latest - 5 versions of k8s which to me seems like a very reasonable support duration.

prashant-shahi · 2023-09-09T03:48:16Z

@jinja2 Thanks for the detailed issue on the behaviour. It was really informative.

Updating the PR to remove the deprecated APIs instead of adding the flag.

…iles Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

dmitryax

LGTM other than the changelog issue

CHANGELOG.md

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

dmitryax

Thank you, @prashant-shahi!

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

TylerHelmuth

Based on this issue, we should update the README that this breaks <= 1.22 users right?

prashant-shahi · 2023-09-11T18:39:29Z

Based on this issue, we should update the README that this breaks <= 1.22 users right?

@TylerHelmuth Include that in changelog? Yeah, sure.

However, I am not sure if we need to include it in README.
It's been around a year since the end of life for 1.22 support.

Ref: https://endoflife.date/kubernetes

TylerHelmuth · 2023-09-11T18:45:56Z

@prashant-shahi if a user enabled this component in a k8s 1.22 cluster with the default values would the collector crash? If so I think we should call that out in the README since there are definitely still people using <= 1.22.

jinja2 · 2023-09-11T18:49:03Z

@TylerHelmuth it won't crash, the receiver will start up ok but HPA metrics will stop. I think a user-facing changelog entry to call out dropped support for the api is good enough.

.chloggen/k8sclusterreceiver-remove-deprecated-resources.yaml

…s.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

prashant-shahi · 2023-09-12T07:34:47Z

@dmitryax @jinja2 @TylerHelmuth Thanks for the thorough review and suggestions in the PR.

Can the related issues be closed now or after the next release?

TylerHelmuth · 2023-09-12T16:43:33Z

@prashant-shahi you can close it now

dmitryax · 2023-09-12T17:13:57Z

Thank you @prashant-shahi for resolving it!

prashant-shahi · 2023-09-13T23:04:49Z

you can close it now

@TylerHelmuth I am unable to close them. Since the related issues were created by other folks.

prashant-shahi added 2 commits September 6, 2023 19:46

feat(k8sclusterreceiver): ✨ introduce ignore_deprecated_resource config

c74fc14

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

docs(k8scluster): 📝 update README and example config

0f7bd1f

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

prashant-shahi requested review from dmitryax and TylerHelmuth as code owners September 7, 2023 18:11

prashant-shahi requested a review from a team September 7, 2023 18:11

github-actions bot assigned MovieStoreGuy Sep 7, 2023

github-actions bot added the receiver/k8scluster label Sep 7, 2023

Merge branch 'main' into chore/flag-autoscaling-v2beta2

6c2e5cb

dmitryax reviewed Sep 7, 2023

View reviewed changes

receiver/k8sclusterreceiver/README.md Outdated Show resolved Hide resolved

prashant-shahi added 3 commits September 8, 2023 11:40

chore: 🚚 rename ignore_deprecated_resource to ignore_deprecated_resou…

1389666

…rces Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

docs(k8scluster): 📝 update changelog

e1d1ae6

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

Merge branch 'main' into chore/flag-autoscaling-v2beta2

1528480

prashant-shahi changed the title ~~feat(k8sclusterreceiver): ✨ introduce ignore_deprecated_resource config~~ feat(k8sclusterreceiver): ✨ introduce ignore_deprecated_resources config Sep 8, 2023

Merge branch 'main' into chore/flag-autoscaling-v2beta2

c1e5f70

refactor(k8sclusterreceiver): ♻️ remove deprecated APIs and related f…

d421469

…iles Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

prashant-shahi changed the title ~~feat(k8sclusterreceiver): ✨ introduce ignore_deprecated_resources config~~ chore(k8sclusterreceiver): 🔥 remove deprecated kubernetes API resources Sep 9, 2023

prashant-shahi added 3 commits September 9, 2023 14:40

Merge branch 'main' into chore/flag-autoscaling-v2beta2

00ebf82

docs(k8sclusterreceiver): 📝 update readme docs

97e1d40

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

docs(k8scluster): 📝 update changelog

a6622b2

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

prashant-shahi requested a review from dmitryax September 9, 2023 10:11

Merge branch 'main' into chore/flag-autoscaling-v2beta2

3eca59a

dmitryax reviewed Sep 11, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

docs(k8scluster): 📝 update changelog generator config instead

ee9e5d7

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

dmitryax approved these changes Sep 11, 2023

View reviewed changes

docs(k8scluster): 📝 update changelog

7a9bea3

Signed-off-by: Prashant Shahi <me@prashantshahi.dev>

TylerHelmuth reviewed Sep 11, 2023

View reviewed changes

dmitryax reviewed Sep 11, 2023

View reviewed changes

.chloggen/k8sclusterreceiver-remove-deprecated-resources.yaml Outdated Show resolved Hide resolved

.chloggen/k8sclusterreceiver-remove-deprecated-resources.yaml Outdated Show resolved Hide resolved

prashant-shahi and others added 3 commits September 12, 2023 00:28

chore: update .chloggen/k8sclusterreceiver-remove-deprecated-resource…

fb9a091

…s.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

chore: update .chloggen/k8sclusterreceiver-remove-deprecated-resource…

b8e0fbb

…s.yaml Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>

Merge branch 'main' into chore/flag-autoscaling-v2beta2

8ace748

TylerHelmuth approved these changes Sep 11, 2023

View reviewed changes

dmitryax merged commit 06dd7e2 into open-telemetry:main Sep 11, 2023
84 checks passed

github-actions bot added this to the next release milestone Sep 11, 2023

prashant-shahi deleted the chore/flag-autoscaling-v2beta2 branch September 11, 2023 19:22

prashant-shahi mentioned this pull request Oct 19, 2023

bump up version to >= 0.85 SigNoz/signoz-otel-collector#200

Closed

jinja2 mentioned this pull request Oct 20, 2023

REQUEST: New membership for jinja2 open-telemetry/community#1749

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(k8sclusterreceiver): 🔥 remove deprecated kubernetes API resources #26516

chore(k8sclusterreceiver): 🔥 remove deprecated kubernetes API resources #26516

prashant-shahi commented Sep 7, 2023 •

edited

Loading

linux-foundation-easycla bot commented Sep 7, 2023 •

edited

Loading

dmitryax left a comment

jinja2 commented Sep 8, 2023

dmitryax commented Sep 8, 2023 •

edited

Loading

prashant-shahi commented Sep 8, 2023 •

edited

Loading

jinja2 commented Sep 8, 2023

prashant-shahi commented Sep 9, 2023 •

edited

Loading

dmitryax left a comment

dmitryax left a comment

TylerHelmuth left a comment

prashant-shahi commented Sep 11, 2023 •

edited

Loading

TylerHelmuth commented Sep 11, 2023

jinja2 commented Sep 11, 2023

prashant-shahi commented Sep 12, 2023

TylerHelmuth commented Sep 12, 2023

dmitryax commented Sep 12, 2023

prashant-shahi commented Sep 13, 2023

chore(k8sclusterreceiver): 🔥 remove deprecated kubernetes API resources #26516

chore(k8sclusterreceiver): 🔥 remove deprecated kubernetes API resources #26516

Conversation

prashant-shahi commented Sep 7, 2023 • edited Loading

linux-foundation-easycla bot commented Sep 7, 2023 • edited Loading

dmitryax left a comment

Choose a reason for hiding this comment

jinja2 commented Sep 8, 2023

dmitryax commented Sep 8, 2023 • edited Loading

prashant-shahi commented Sep 8, 2023 • edited Loading

jinja2 commented Sep 8, 2023

prashant-shahi commented Sep 9, 2023 • edited Loading

dmitryax left a comment

Choose a reason for hiding this comment

dmitryax left a comment

Choose a reason for hiding this comment

TylerHelmuth left a comment

Choose a reason for hiding this comment

prashant-shahi commented Sep 11, 2023 • edited Loading

TylerHelmuth commented Sep 11, 2023

jinja2 commented Sep 11, 2023

prashant-shahi commented Sep 12, 2023

TylerHelmuth commented Sep 12, 2023

dmitryax commented Sep 12, 2023

prashant-shahi commented Sep 13, 2023

prashant-shahi commented Sep 7, 2023 •

edited

Loading

linux-foundation-easycla bot commented Sep 7, 2023 •

edited

Loading

dmitryax commented Sep 8, 2023 •

edited

Loading

prashant-shahi commented Sep 8, 2023 •

edited

Loading

prashant-shahi commented Sep 9, 2023 •

edited

Loading

prashant-shahi commented Sep 11, 2023 •

edited

Loading