Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CODEOWNERS]: add frzifus to jaeger translator and basic auth #24572

Merged
merged 2 commits into from
Jul 27, 2023
Merged

[CODEOWNERS]: add frzifus to jaeger translator and basic auth #24572

merged 2 commits into from
Jul 27, 2023

Conversation

frzifus
Copy link
Member

@frzifus frzifus commented Jul 26, 2023

Description:

Link to tracking Issue:

Testing:

Documentation:

@frzifus frzifus requested review from a team and djaglowski July 26, 2023 16:34
@frzifus frzifus added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jul 26, 2023
@atoulme
Copy link
Contributor

atoulme commented Jul 26, 2023

Sorry @frzifus we just changed how codeowners work. Update this line:
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/extension/basicauthextension/metadata.yaml#L14
and the same line for the other component, then run
make gengithub and make generate in the repository root to regenerate code.

@frzifus
[CODEOWNERS]: add frzifus to jaeger translator and basic auth
0ad0363 
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
@frzifus frzifus requested a review from a team July 26, 2023 21:48
@dmitryax dmitryax merged commit aa83b11 into open-telemetry:main Jul 27, 2023
88 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoulme atoulme atoulme approved these changes

@jpkrohling jpkrohling jpkrohling approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski

Assignees

@codeboten codeboten

Labels
extension/basicauth pkg/translator/jaeger Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.82.0
Development

Successfully merging this pull request may close these issues.
5 participants
@frzifus @atoulme @jpkrohling @codeboten @dmitryax