-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[exporter/datadog] Enable inframetadata.Reporter #24290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
exporter/datadog
Datadog components
labels
Jul 17, 2023
github-actions
bot
requested review from
dineshg13,
dmitryax,
gbbr,
liustanley,
pmcollins and
songy23
July 17, 2023 11:53
mx-psi
force-pushed
the
mx-psi/reporter
branch
2 times, most recently
from
July 17, 2023 14:17
6ffc5f5
to
290fe97
Compare
songy23
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, otherwise LGTM
songy23
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
songy23
added
the
ready to merge
Code review completed; ready to merge by maintainers
label
Jul 18, 2023
mx-psi
force-pushed
the
mx-psi/reporter
branch
3 times, most recently
from
July 19, 2023 10:50
5684829
to
1eba0cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmd/configschema
configschema command
cmd/otelcontribcol
otelcontribcol command
exporter/datadog
Datadog components
ready to merge
Code review completed; ready to merge by maintainers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Enables
inframetadata.Reporter
. This allows sending host metadata based on resource payloads that have the booleandatadog.host.use_as_metadata
set totrue
.By default, host metadata payloads will not be sent by default.
Depends on #24271