Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/datadog] Enable inframetadata.Reporter #24290

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 17, 2023

Description:

Enables inframetadata.Reporter. This allows sending host metadata based on resource payloads that have the boolean datadog.host.use_as_metadata set to true.

By default, host metadata payloads will not be sent by default.

Depends on #24271

@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components labels Jul 17, 2023
@mx-psi mx-psi force-pushed the mx-psi/reporter branch 2 times, most recently from 6ffc5f5 to 290fe97 Compare July 17, 2023 14:17
@mx-psi mx-psi marked this pull request as ready for review July 17, 2023 16:01
@mx-psi mx-psi requested a review from a team July 17, 2023 16:01
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

exporter/datadogexporter/factory.go Outdated Show resolved Hide resolved
exporter/datadogexporter/factory.go Outdated Show resolved Hide resolved
exporter/datadogexporter/factory.go Outdated Show resolved Hide resolved
@mx-psi mx-psi requested a review from songy23 July 18, 2023 11:47
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Jul 18, 2023
@mx-psi mx-psi force-pushed the mx-psi/reporter branch 3 times, most recently from 5684829 to 1eba0cd Compare July 19, 2023 10:50
@mx-psi mx-psi merged commit e8ffc51 into open-telemetry:main Jul 19, 2023
@github-actions github-actions bot added this to the next release milestone Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants