-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hostmetricsreceiver]: support reporting amount of available logical and physical CPUs #23231
Merged
dmitryax
merged 2 commits into
open-telemetry:main
from
frzifus:hostmetricsreceiver_support_cpu_count
Aug 2, 2023
Merged
[hostmetricsreceiver]: support reporting amount of available logical and physical CPUs #23231
dmitryax
merged 2 commits into
open-telemetry:main
from
frzifus:hostmetricsreceiver_support_cpu_count
Aug 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Jun 8, 2023
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
frzifus
commented
Jun 8, 2023
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/cpu_scraper_linux.go
Outdated
Show resolved
Hide resolved
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
June 8, 2023 14:17
c950113
to
a3a3ba9
Compare
Blocked by open-telemetry/semantic-conventions#99 |
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
June 19, 2023 15:05
a3a3ba9
to
0a4e378
Compare
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
July 7, 2023 21:21
0a4e378
to
50c675c
Compare
frzifus
changed the title
[hostmetricsreceiver]: support reporting amount of available CPUs
[hostmetricsreceiver]: support reporting amount of available logical and physical CPUs
Jul 7, 2023
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
July 7, 2023 21:28
50c675c
to
842b7ee
Compare
mx-psi
reviewed
Jul 10, 2023
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/cpu_scraper_others.go
Outdated
Show resolved
Hide resolved
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
4 times, most recently
from
July 18, 2023 15:27
2ca0d29
to
f201f8e
Compare
dmitryax
reviewed
Jul 18, 2023
receiver/hostmetricsreceiver/internal/scraper/processscraper/process_scraper_others.go
Outdated
Show resolved
Hide resolved
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
July 18, 2023 21:57
f201f8e
to
67ddac1
Compare
dmitryax
reviewed
Jul 18, 2023
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/documentation.md
Outdated
Show resolved
Hide resolved
dmitryax
reviewed
Jul 18, 2023
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/metadata.yaml
Outdated
Show resolved
Hide resolved
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
July 18, 2023 22:53
67ddac1
to
ff4541f
Compare
dmitryax
reviewed
Jul 19, 2023
receiver/hostmetricsreceiver/internal/scraper/cpuscraper/cpu_scraper_linux.go
Outdated
Show resolved
Hide resolved
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
2 times, most recently
from
July 19, 2023 09:12
249cf22
to
703aebd
Compare
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
July 26, 2023 21:55
703aebd
to
635919c
Compare
I assume we can pickup this again. Since the open-telemetry/semantic-conventions#99 got merged. cc @mx-psi |
mx-psi
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, needs a rebase
…and physical CPUs Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
hostmetricsreceiver_support_cpu_count
branch
from
August 2, 2023 09:22
635919c
to
1e550ef
Compare
Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
dmitryax
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue:
Testing:
Manually:
Got:
Documentation:
documentation.md
was automatically updated bymdatagen
.