Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhookevent client #20751

Merged
merged 52 commits into from
Jun 6, 2023
Merged

Conversation

shalper2
Copy link
Contributor

@shalper2 shalper2 commented Apr 7, 2023

Description: Implemented the component. It works by standing up a server with a route to accept post requests from the webhook its configured to receive from. These requests are then converted into otel logs and shipped. Can handle gzip encoded payloads.

Link to tracking Issue: 18101

Testing: Basic unit testing for each code section

Documentation: Documentation is largely unchanged. Proper readme will likely be included in a separate PR

@runforesight
Copy link

runforesight bot commented Apr 7, 2023

Foresight Summary

    
Major Impacts

build-and-test-windows duration(6 seconds) has decreased 30 minutes 28 seconds compared to main branch avg(30 minutes 34 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 6 seconds (30 minutes 28 seconds less than main branch avg.) and finished at 13th Apr, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 53 seconds and finished at 13th Apr, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 6 seconds and finished at 13th Apr, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 3 seconds and finished at 13th Apr, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 3 minutes 10 seconds (3 minutes 10 seconds less than main branch avg.) and finished at 13th Apr, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

✅  load-tests workflow has finished in 7 minutes 8 seconds (3 minutes 22 seconds less than main branch avg.) and finished at 13th Apr, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 12 minutes 24 seconds (1 minute 39 seconds less than main branch avg.) and finished at 13th Apr, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

❌  build-and-test workflow has finished in 17 minutes 51 seconds (28 minutes 48 seconds less than main branch avg.) and finished at 13th Apr, 2023. 2 jobs failed.


Job Failed Steps Tests
govulncheck -     🔗  N/A See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
checks -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
integration-tests -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) Lint     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (connector) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest-matrix (1.20, processor) -     🔗  N/A See Details
unittest-matrix (1.20, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.20, exporter) -     🔗  N/A See Details
unittest-matrix (1.20, extension) -     🔗  N/A See Details
unittest-matrix (1.20, connector) -     🔗  N/A See Details
unittest-matrix (1.20, internal) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, connector) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
lint Interpret result     🔗  N/A See Details
cross-compile -     🔗  N/A See Details
build-package -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
rotate-milestone -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@shalper2 shalper2 force-pushed the webhookevent_client branch 3 times, most recently from 5a7d8ad to 1a19687 Compare April 17, 2023 20:26
@shalper2 shalper2 force-pushed the webhookevent_client branch 2 times, most recently from ff0904f to 7824918 Compare April 21, 2023 14:02
@shalper2
Copy link
Contributor Author

Curious if anyone has thoughts about what to add as attributes to the log

@shalper2 shalper2 marked this pull request as ready for review April 24, 2023 13:25
@shalper2 shalper2 requested a review from a team April 24, 2023 13:25
@shalper2 shalper2 marked this pull request as draft April 24, 2023 15:36
@shalper2 shalper2 marked this pull request as ready for review April 24, 2023 15:41
@shalper2 shalper2 force-pushed the webhookevent_client branch 3 times, most recently from 18ce546 to 668bec6 Compare April 25, 2023 00:40
@github-actions github-actions bot requested a review from altuner April 25, 2023 00:41
@shalper2 shalper2 force-pushed the webhookevent_client branch 4 times, most recently from d08eb0f to b1087ed Compare May 1, 2023 21:07
@shalper2 shalper2 force-pushed the webhookevent_client branch 4 times, most recently from 7455888 to 40fda2e Compare May 9, 2023 16:33
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience @shalper2!

@codeboten codeboten merged commit 99bd0a9 into open-telemetry:main Jun 6, 2023
@github-actions github-actions bot added this to the next release milestone Jun 6, 2023
@shalper2 shalper2 deleted the webhookevent_client branch June 12, 2023 14:04
Caleb-Hurshman pushed a commit to observIQ/opentelemetry-collector-contrib that referenced this pull request Jul 6, 2023
Implemented the component. It works by standing up a server with a route to accept post requests from the webhook its configured to receive from. These requests are then converted into otel logs and shipped. Can handle gzip encoded payloads.

Link to tracking Issue: 18101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/azuremonitor receiver/webhookevent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants