Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/webhookevent] First commit #19377

Merged
merged 13 commits into from
Mar 10, 2023

Conversation

shalper2
Copy link
Contributor

@shalper2 shalper2 commented Mar 7, 2023

Description: New Generic Webhook Component.

Link to tracking Issue: Updates 18101

Testing: Simple functional testing comparable with other components

Documentation: Initial documentation. There is not much yet, this is just a wireframe to be fleshed out later.

@shalper2 shalper2 requested review from a team and bogdandrutu March 7, 2023 19:50
@runforesight
Copy link

runforesight bot commented Mar 7, 2023

Foresight Summary

    
Major Impacts

build-and-test duration(41 minutes 36 seconds) has decreased 23 minutes 51 seconds compared to main branch avg(1 hour 5 minutes 27 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 6 seconds (43 minutes 29 seconds less than main branch avg.) and finished at 10th Mar, 2023.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 13 seconds (54 seconds less than main branch avg.) and finished at 10th Mar, 2023.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 25 seconds and finished at 10th Mar, 2023.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 15 seconds and finished at 10th Mar, 2023.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 10 minutes 57 seconds (⚠️ 3 minutes 11 seconds more than main branch avg.) and finished at 10th Mar, 2023.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 17 minutes 32 seconds (⚠️ 2 minutes 20 seconds more than main branch avg.) and finished at 10th Mar, 2023.


Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  load-tests workflow has finished in 17 minutes 43 seconds (⚠️ 4 minutes 2 seconds more than main branch avg.) and finished at 10th Mar, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

✅  build-and-test workflow has finished in 41 minutes 36 seconds (23 minutes 51 seconds less than main branch avg.) and finished at 10th Mar, 2023.


Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (connector) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
integration-tests -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
unittest-matrix (1.20, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.20, processor) -     🔗  N/A See Details
unittest-matrix (1.20, exporter) -     🔗  N/A See Details
unittest-matrix (1.20, extension) -     🔗  N/A See Details
unittest-matrix (1.20, connector) -     🔗  N/A See Details
unittest-matrix (1.20, internal) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, connector) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@shalper2
Copy link
Contributor Author

shalper2 commented Mar 7, 2023

@atoulme new PR appears to pass the CLA check

@djaglowski djaglowski changed the title First commit [receiver/genericwebhook] First commit Mar 8, 2023
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious to see how the implementation of this receiver looks, but the name seems a bit unclear to me. Does the work "generic" really add anything here? Should it include the word "logs" or "logs", since we're modeling the data as logs? e.g. webhooklogreceiver

receiver/genericwebhookreceiver/Makefile Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/README.md Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/factory.go Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/config.go Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/config_test.go Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/factory.go Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/factory_test.go Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/receiver.go Outdated Show resolved Hide resolved
receiver/genericwebhookreceiver/receiver_test.go Outdated Show resolved Hide resolved
@shalper2 shalper2 changed the title [receiver/genericwebhook] First commit [receiver/webhookevent] First commit Mar 8, 2023
.chloggen/generic_webhook_wireframe.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/bug_report.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/feature_request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/other.yaml Outdated Show resolved Hide resolved
receiver/webhookeventreceiver/Makefile Outdated Show resolved Hide resolved
receiver/webhookeventreceiver/README.md Outdated Show resolved Hide resolved
@shalper2
Copy link
Contributor Author

shalper2 commented Mar 9, 2023

@djaglowski thanks for catching all of those rename misses!

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 9, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shalper2 (bce23c609764b90cc857ecba34cd972870985a6f, 17ac0bc843f5090a33e89bae331cffd95f0652ca, 9211d33e19b91941e52af04986048183ace12e2c, 947cb6c54e6b915e60b0bab9e90e164803fa756a, a1214ce3cd3d1ea2257a1b8ea527298fed52a0e9, aa9c27055138a04a232b966a2f6276bd8b806e94, d1cf514278564fd4f19e62467b8cad8fe2231972, 8aba13cb8dbe99d78205c434cca3e4256469e14c, 7a2c4f32c8e0471ff5dcd92d0497beb6905cd55e, 7270c6880b96e6a358da00dd988bedcfb1e86c1b, 5eae723e9fd59dbb79d8261917d3812eb87a7175)

@djaglowski
Copy link
Member

/easycla

@shalper2 shalper2 force-pushed the generic_webhook_wireframe branch 2 times, most recently from e003ff6 to f000710 Compare March 9, 2023 21:11
@atoulme
Copy link
Contributor

atoulme commented Mar 9, 2023

Tests fail with #9113, we can rerun that one in a bit.

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Mar 9, 2023
@djaglowski
Copy link
Member

@shalper2, I tried to resolve the conflict manually but it failed. Will you please run make gendependabot and push the changes?

@djaglowski djaglowski merged commit cf47a1b into open-telemetry:main Mar 10, 2023
@shalper2 shalper2 deleted the generic_webhook_wireframe branch June 12, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants