[connector/spanmetricsconnector]: Migrate from spanmtricsprocessor

[Cluas]

Description:

Migrate from spanmtricsprocessor

Link to tracking Issue:
#18697
Testing:

Documentation:

[Cluas]

cc@kovrus

[kovrus]

@Cluas can we split it into a few PRs. Now the migration and changes are mixed.

• split spanconnector processor code base -> spanconnector processor and spanconnector connector without changes to metrics generation logic.
• drop _total, there is an issue open that [connectors/spanmetrics] Drop _total from generated metrics names. #18677
• rename operation to span.name, there is an issue open for that [connectors/spanmetrics] Rename the operation attribute to span.name  #18529
• we can hold on with [processor/spanmetricsprocessor] Support set metrics namespace. #18697 before this split happens.

Then we can follow up with the rest of issues connector/spanmetrics

[Cluas]

@Cluas can we split it into a few PRs. Now the migration and changes are mixed.

• split spanconnector processor code base -> spanconnector processor and spanconnector connector without changes to metrics generation logic.
• drop _total, there is an issue open that [connectors/spanmetrics] Drop _total from generated metrics names. #18677
• rename operation to span.name, there is an issue open for that [connectors/spanmetrics] Rename the operation attribute to span.name  #18529
• we can hold on with [processor/spanmetricsprocessor] Support set metrics namespace. #18697 before this split happens.

Then we can follow up with the rest of issues connector/spanmetrics

ok, when #18697 done, I will merge change to it. Than add two PR, one for drop _total, another one for renaming operation -> span.kind

[runforesight]

Foresight Summary

    
Major Impacts

TestStartAndShutdownRemote ❌ failed 1 times in 10 runs (10% fail rate).

build-and-test duration(39 minutes 38 seconds) has decreased 26 minutes 45 seconds compared to main branch avg(1 hour 6 minutes 23 seconds).

View More Details

⭕  changelog workflow has finished in 3 seconds (2 minutes 33 seconds less than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
changelog	-     🔗	N/A	See Details

---

⭕  build-and-test-windows workflow has finished in 5 seconds (40 minutes 56 seconds less than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
windows-unittest-matrix	-     🔗	N/A	See Details
windows-unittest	-     🔗	N/A	See Details

---

✅  check-links workflow has finished in 1 minute 33 seconds (59 seconds less than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
changed files	-     🔗	N/A	See Details
check-links	-     🔗	N/A	See Details

---

✅  telemetrygen workflow has finished in 1 minute 2 seconds (2 minutes 2 seconds less than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
build-dev	-     🔗	N/A	See Details
publish-latest	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details

---

✅  prometheus-compliance-tests workflow has finished in 3 minutes 30 seconds (5 minutes 14 seconds less than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
prometheus-compliance-tests	-     🔗	✅ 21  ❌ 0  ⏭ 0    🔗	See Details

---

✅  e2e-tests workflow has finished in 11 minutes 25 seconds (4 minutes 30 seconds less than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
kubernetes-test	-     🔗	N/A	See Details

---

✅  load-tests workflow has finished in 22 minutes 3 seconds (⚠️ 5 minutes 21 seconds more than main branch avg.) and finished at 16th Feb, 2023.

---

Job	Failed Steps	Tests
loadtest (TestTraceAttributesProcessor)	-     🔗	✅ 3  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile)	-     🔗	✅ 6  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestIdleMode)	-     🔗	✅ 1  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs)	-     🔗	✅ 8  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS)	-     🔗	✅ 12  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs)	-     🔗	✅ 10  ❌ 0  ⏭ 0    🔗	See Details
loadtest (TestBallastMemory|TestLog10kDPS)	-     🔗	✅ 18  ❌ 0  ⏭ 0    🔗	See Details
setup-environment	-     🔗	N/A	See Details

---

✅  build-and-test workflow has finished in 39 minutes 38 seconds (26 minutes 45 seconds less than main branch avg.) and finished at 17th Feb, 2023.

---

Job	Failed Steps	Tests
lint-matrix (other)	-     🔗	N/A	See Details
lint	-     🔗	N/A	See Details
cross-compile (darwin, amd64)	-     🔗	N/A	See Details
cross-compile (darwin, arm64)	-     🔗	N/A	See Details
cross-compile (linux, 386)	-     🔗	N/A	See Details
cross-compile (linux, amd64)	-     🔗	N/A	See Details
cross-compile (linux, arm)	-     🔗	N/A	See Details
cross-compile (linux, arm64)	-     🔗	N/A	See Details
cross-compile (linux, ppc64le)	-     🔗	N/A	See Details
cross-compile (windows, 386)	-     🔗	N/A	See Details
cross-compile (windows, amd64)	-     🔗	N/A	See Details
build-package (deb)	-     🔗	N/A	See Details
build-package (rpm)	-     🔗	N/A	See Details
windows-msi	-     🔗	N/A	See Details
publish-check	-     🔗	N/A	See Details
publish-dev	-     🔗	N/A	See Details
publish-stable	-     🔗	N/A	See Details

---

🔎 See details on Foresight

^{*You can configure Foresight comments in your organization settings page.}

[Cluas]

Do we need to remove the connector port part from the spanmetricsprocessor later?

[kovrus]

Do we need to remove the connector port part from the spanmetricsprocessor later?

I missed that. Let's remove that in this PR.

And thanks for doing this!

[Cluas]

Do we need to remove the connector port part from the spanmetricsprocessor later?

I missed that. Let's remove that in this PR.

And thanks for doing this!

done. PTAL

[djaglowski]

I am confused about the scope of this PR. Is the purpose only to separate the processor and connector implementations?

[Cluas]

I am confused about the scope of this PR. Is the purpose only to separate the processor and connector implementations?

Yes, then a change to the metric name is applied to the connector. Separate PR will do it:

1. drop _total, rename calls_total -> calls [connectors/spanmetrics] Drop _total from generated metrics names. #18677
2. rename operation -> span.name [connectors/spanmetrics] Rename the operation attribute to span.name  #18529

[djaglowski]

LGTM, just one question about follow up work.

[kovrus]

lgtm