Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cassandra exporter implementation #18515

Merged
merged 37 commits into from
Apr 22, 2023
Merged

Cassandra exporter implementation #18515

merged 37 commits into from
Apr 22, 2023

Conversation

emreyalvac
Copy link
Member

Description:
Cassandra Exporter for traces and logs

Link to tracking Issue: #17910

@emreyalvac emreyalvac requested a review from a team February 12, 2023 12:06
@emreyalvac emreyalvac mentioned this pull request Feb 12, 2023
Closed
2 tasks
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol labels Feb 12, 2023
@github-actions github-actions bot requested a review from pmcollins February 12, 2023 12:07
@emreyalvac emreyalvac mentioned this pull request Feb 12, 2023
Closed
@runforesight
Copy link

runforesight bot commented Feb 12, 2023 •
edited
Loading

Foresight Summary

    
Major Impacts
Foresight hasn't detected any major impact on your workflows and tests.

View More Details

⭕  build-and-test-windows workflow has finished in 6 seconds (30 minutes 24 seconds less than main branch avg.) and finished at 14th Apr, 2023.

Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  telemetrygen workflow has finished in 1 minute 19 seconds and finished at 14th Apr, 2023.

Job Failed Steps Tests
publish-stable -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
build-dev -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 26 seconds and finished at 14th Apr, 2023.

Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  changelog workflow has finished in 2 minutes 19 seconds and finished at 14th Apr, 2023.

Job Failed Steps Tests
changelog -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 13 minutes 5 seconds (⚠️ 6 minutes 45 seconds more than main branch avg.) and finished at 14th Apr, 2023.

Job Failed Steps Tests
prometheus-compliance-tests -     🔗  N/A See Details

✅  e2e-tests workflow has finished in 16 minutes 26 seconds (⚠️ 2 minutes 23 seconds more than main branch avg.) and finished at 14th Apr, 2023.

Job Failed Steps Tests
kubernetes-test (v1.26.0) -     🔗  N/A See Details
kubernetes-test (v1.25.3) -     🔗  N/A See Details
kubernetes-test (v1.24.7) -     🔗  N/A See Details
kubernetes-test (v1.23.13) -     🔗  N/A See Details

✅  load-tests workflow has finished in 25 minutes 17 seconds (⚠️ 14 minutes 48 seconds more than main branch avg.) and finished at 14th Apr, 2023.

Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  N/A See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  N/A See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  N/A See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  N/A See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  N/A See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  N/A See Details
loadtest (TestTraceAttributesProcessor) -     🔗  N/A See Details

❌  build-and-test workflow has finished in 42 minutes 36 seconds and finished at 14th Apr, 2023. 0 job failed.

Job Failed Steps Tests
setup-environment -     🔗  N/A See Details
govulncheck -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (connector) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
checks -     🔗  N/A See Details
correctness-metrics -     🔗  N/A See Details
correctness-traces -     🔗  N/A See Details
integration-tests -     🔗  N/A See Details
unittest-matrix (1.20, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.20, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.20, processor) -     🔗  N/A See Details
unittest-matrix (1.20, exporter) -     🔗  N/A See Details
unittest-matrix (1.20, extension) -     🔗  N/A See Details
unittest-matrix (1.20, connector) -     🔗  N/A See Details
unittest-matrix (1.20, internal) -     🔗  N/A See Details
unittest-matrix (1.20, other) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-0) -     🔗  N/A See Details
unittest-matrix (1.19, receiver-1) -     🔗  N/A See Details
unittest-matrix (1.19, processor) -     🔗  N/A See Details
unittest-matrix (1.19, exporter) -     🔗  N/A See Details
unittest-matrix (1.19, extension) -     🔗  N/A See Details
unittest-matrix (1.19, connector) -     🔗  N/A See Details
unittest-matrix (1.19, internal) -     🔗  N/A See Details
unittest-matrix (1.19, other) -     🔗  N/A See Details
unittest (1.20) -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details
rotate-milestone -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@emreyalvac
Copy link
Member Author

I will continue this implementation from this PR due to branch issue.

Old PR: #18416

@emreyalvac
Copy link
Member Author

emreyalvac commented Feb 12, 2023 •
edited
Loading

@atoulme Thanks for your time and review.

I fixed your comments and added your comments links.

@atoulme
Copy link
Contributor

atoulme commented Feb 12, 2023

Please fix linting issues. Run make lint in the folder.
Your tests should pass too.

@atoulme
Copy link
Contributor

atoulme commented Feb 15, 2023

Would you please resolve the conflict? You can rebase or merge.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2023

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 2, 2023
@atoulme atoulme added Accepted Component New component has been sponsored and removed Stale cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol labels Mar 12, 2023
@atoulme
Copy link
Contributor

atoulme commented Mar 12, 2023

@emreyalvac do you need help to rebase? Please let us know.

@emreyalvac emreyalvac requested a review from atoulme April 10, 2023 16:34
@atoulme
Copy link
Contributor

atoulme commented Apr 12, 2023

Please fix the conflict.

@atoulme
Copy link
Contributor

atoulme commented Apr 12, 2023 

--- FAIL: TestDefaultExporters (173.53s)
    --- FAIL: TestDefaultExporters/cassandra (0.00s)
        exporters_test.go:535: 
            	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/otelcontribcol/exporters_test.go:535
            	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/cmd/otelcontribcol/exporters_test.go:[49](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4636123642/jobs/8203774990?pr=18515#step:8:50)7
            	Error:      	Received unexpected error:
            	            	cannot configure cassandra traces exporter: gocql: unable to create session: unable to discover protocol version: dial tcp 127.0.0.1:9042: connect: connection refused
            	Test:       	TestDefaultExporters/cassandra

Make sure you set the exporter test to skip lifecycle to avoid this issue.

@emreyalvac emreyalvac requested review from atoulme and dmitryax April 13, 2023 08:07
@atoulme
Copy link
Contributor

atoulme commented Apr 13, 2023

OK it looks close but please address the feedback from @dmitryax so we can get this in.

@emreyalvac
Copy link
Member Author

@atoulme This test is failed due to timeout.

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/4708214556/jobs/8350532912?pr=18515

@atoulme atoulme added the ready to merge Code review completed; ready to merge by maintainers label Apr 20, 2023
@atoulme
Copy link
Contributor

atoulme commented Apr 20, 2023

This looks ready to merge to me.

mx-psi
mx-psi reviewed Apr 21, 2023
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
@emreyalvac emreyalvac requested a review from mx-psi April 22, 2023 13:42
@dmitryax dmitryax merged commit 691044b into open-telemetry:main Apr 22, 2023
@github-actions github-actions bot added this to the next release milestone Apr 22, 2023
@emreyalvac emreyalvac mentioned this pull request Nov 7, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@pmcollins pmcollins Awaiting requested review from pmcollins

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@mx-psi mx-psi Awaiting requested review from mx-psi

Assignees

@TylerHelmuth TylerHelmuth

Labels
Accepted Component New component has been sponsored cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command cmd/oteltestbedcol ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.76.3
Development

Successfully merging this pull request may close these issues.
5 participants
@emreyalvac @atoulme @mx-psi @dmitryax @TylerHelmuth