-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[internal/comparetest] Sort resource metrics by attributes #17179
Merged
djaglowski
merged 2 commits into
open-telemetry:main
from
dmitryax:sort-resource-metrics-by-attributes
Dec 27, 2022
Merged
[internal/comparetest] Sort resource metrics by attributes #17179
djaglowski
merged 2 commits into
open-telemetry:main
from
dmitryax:sort-resource-metrics-by-attributes
Dec 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
requested review from
djaglowski,
dashpole,
codeboten and
MovieStoreGuy
as code owners
December 20, 2022 19:46
github-actions
bot
added
exporter/datadog
Datadog components
internal/comparetest
internal/core
pkg/winperfcounters
processor/metricstransform
Metrics Transform processor
receiver/activedirectoryds
receiver/aerospike
receiver/apache
receiver/bigip
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/flinkmetrics
receiver/httpcheck
HTTP Check receiver
receiver/iis
receiver/memcached
receiver/mongodb
receiver/mysql
receiver/nginx
receiver/nsxt
NSXT Receiver
receiver/postgresql
labels
Dec 20, 2022
github-actions
bot
added
receiver/rabbitmq
receiver/riak
receiver/saphana
receiver/snmp
receiver/sqlquery
SQL query receiver
receiver/sqlserver
receiver/vcenter
receiver/windowsperfcounters
receiver/zookeeper
labels
Dec 20, 2022
@djaglowski PTAL whenever you have a chance |
Foresight Summary
View More Details⭕ changelog workflow has finished in 4 seconds (8 minutes 58 seconds less than
|
Job | Failed Steps | Tests | |
---|---|---|---|
changelog | - 🔗 | N/A | See Details |
⭕ build-and-test-windows workflow has finished in 4 seconds (43 minutes 35 seconds less than main
branch avg.) and finished at 20th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
windows-unittest-matrix | - 🔗 | N/A | See Details |
windows-unittest | - 🔗 | N/A | See Details |
✅ check-links workflow has finished in 48 seconds (2 minutes 43 seconds less than main
branch avg.) and finished at 20th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
changed files | - 🔗 | N/A | See Details |
check-links | - 🔗 | N/A | See Details |
✅ tracegen workflow has finished in 1 minute 12 seconds (2 minutes 39 seconds less than main
branch avg.) and finished at 20th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
build-dev | - 🔗 | N/A | See Details |
publish-latest | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ build-and-test workflow has finished in 43 minutes 43 seconds (16 minutes 14 seconds less than main
branch avg.) and finished at 20th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
unittest-matrix (1.18, internal) | - 🔗 | ✅ 597 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, internal) | - 🔗 | ✅ 597 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-metrics | - 🔗 | ✅ 2 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, processor) | - 🔗 | ✅ 1474 ❌ 0 ⏭ 0 🔗 | See Details |
correctness-traces | - 🔗 | ✅ 17 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, processor) | - 🔗 | ✅ 1474 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, extension) | - 🔗 | ✅ 528 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-0) | - 🔗 | ✅ 2539 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-0) | - 🔗 | ✅ 2539 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, exporter) | - 🔗 | ✅ 2456 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, exporter) | - 🔗 | ✅ 2456 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, other) | - 🔗 | ✅ 4394 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, other) | - 🔗 | ✅ 4394 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.19, receiver-1) | - 🔗 | ✅ 1871 ❌ 0 ⏭ 0 🔗 | See Details |
unittest-matrix (1.18, receiver-1) | - 🔗 | ✅ 1871 ❌ 0 ⏭ 0 🔗 | See Details |
integration-tests | - 🔗 | ✅ 55 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
check-collector-module-version | - 🔗 | N/A | See Details |
check-codeowners | - 🔗 | N/A | See Details |
checks | - 🔗 | N/A | See Details |
lint-matrix (receiver-1) | - 🔗 | N/A | See Details |
lint-matrix (receiver-0) | - 🔗 | N/A | See Details |
lint-matrix (processor) | - 🔗 | N/A | See Details |
lint-matrix (exporter) | - 🔗 | N/A | See Details |
lint-matrix (internal) | - 🔗 | N/A | See Details |
lint-matrix (other) | - 🔗 | N/A | See Details |
lint-matrix (extension) | - 🔗 | N/A | See Details |
build-examples | - 🔗 | N/A | See Details |
unittest (1.19) | - 🔗 | N/A | See Details |
unittest (1.18) | - 🔗 | N/A | See Details |
lint | - 🔗 | N/A | See Details |
cross-compile (darwin, amd64) | - 🔗 | N/A | See Details |
cross-compile (darwin, arm64) | - 🔗 | N/A | See Details |
cross-compile (linux, 386) | - 🔗 | N/A | See Details |
cross-compile (linux, amd64) | - 🔗 | N/A | See Details |
cross-compile (linux, arm) | - 🔗 | N/A | See Details |
cross-compile (linux, ppc64le) | - 🔗 | N/A | See Details |
cross-compile (linux, arm64) | - 🔗 | N/A | See Details |
cross-compile (windows, 386) | - 🔗 | N/A | See Details |
cross-compile (windows, amd64) | - 🔗 | N/A | See Details |
build-package (deb) | - 🔗 | N/A | See Details |
build-package (rpm) | - 🔗 | N/A | See Details |
windows-msi | - 🔗 | N/A | See Details |
publish-dev | - 🔗 | N/A | See Details |
publish-check | - 🔗 | N/A | See Details |
publish-stable | - 🔗 | N/A | See Details |
✅ load-tests workflow has finished in 9 minutes 1 second (8 minutes 28 seconds less than main
branch avg.) and finished at 20th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
loadtest (TestIdleMode) | - 🔗 | ✅ 1 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceAttributesProcessor) | - 🔗 | ✅ 3 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetric10kDPS|TestMetricsFromFile) | - 🔗 | ✅ 6 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) | - 🔗 | ✅ 8 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) | - 🔗 | ✅ 12 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) | - 🔗 | ✅ 10 ❌ 0 ⏭ 0 🔗 | See Details |
loadtest (TestBallastMemory|TestLog10kDPS) | - 🔗 | ✅ 19 ❌ 0 ⏭ 0 🔗 | See Details |
setup-environment | - 🔗 | N/A | See Details |
✅ prometheus-compliance-tests workflow has finished in 13 minutes 42 seconds (⚠️ 3 minutes 43 seconds more than main
branch avg.) and finished at 20th Dec, 2022.
Job | Failed Steps | Tests | |
---|---|---|---|
prometheus-compliance-tests | - 🔗 | ✅ 21 ❌ 0 ⏭ 0 🔗 | See Details |
*You can configure Foresight comments in your organization settings page.
dmitryax
changed the title
Sort resource metrics by attributes
[internal/comparetest] Sort resource metrics by attributes
Dec 20, 2022
The function supposed to be used in places where data need to be grouped by attributes map. Adding it in contrib for now until it's ready to be moved to core
dmitryax
force-pushed
the
sort-resource-metrics-by-attributes
branch
from
December 20, 2022 22:55
34405fc
to
57c34f4
Compare
Sort ResourceMetrics by attributes using the new map hash function. It brings the sorting behavior to consistency with the sorting of ScopeMetrics
dmitryax
force-pushed
the
sort-resource-metrics-by-attributes
branch
from
December 20, 2022 23:11
57c34f4
to
2ef92bf
Compare
djaglowski
approved these changes
Dec 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
exporter/datadog
Datadog components
internal/comparetest
internal/core
pkg/winperfcounters
processor/metricstransform
Metrics Transform processor
receiver/activedirectoryds
receiver/aerospike
receiver/apache
receiver/bigip
receiver/couchdb
receiver/dockerstats
receiver/elasticsearch
receiver/expvar
receiver/flinkmetrics
receiver/httpcheck
HTTP Check receiver
receiver/iis
receiver/memcached
receiver/mongodb
receiver/mysql
receiver/nginx
receiver/nsxt
NSXT Receiver
receiver/postgresql
receiver/rabbitmq
receiver/riak
receiver/saphana
receiver/snmp
receiver/sqlquery
SQL query receiver
receiver/sqlserver
receiver/vcenter
receiver/windowsperfcounters
receiver/zookeeper
Skip Changelog
PRs that do not require a CHANGELOG.md entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sort ResourceMetrics by attributes using the new map hash function. It brings the sorting behavior to consistency with the sorting of ScopeMetrics.
This change also applies a correction to the
TestCompareMetrics/ignore-one-resource-attribute-multiple-resources
test case. It is used to compare several ResourceMetrics with the same resource attributes relying on a different number of datapoints synthetically adjusted to have a deterministic order with the existing logic, but the different number of datapoints is not a real scenario in any of the existing scraping receivers. This change simplifies the actual/expected test datasets to have different attributes for each ResourceMetrics instance.Depends on #17169