Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

processor: add datadogprocessor #16853

Merged
merged 8 commits into from
Dec 13, 2022

Conversation

gbbr
Copy link
Member

@gbbr gbbr commented Dec 12, 2022

This change adds the processor described in #15689. It is the initial PR containing the structure and implementation as per contribution guidelines.

I added the implementation too, because it is a trivial, small one. If necessary, I am happy to split more. Besides the processor/datadogprocessor/agent.go file, the rest is boilerplate.

Requires #16852

@gbbr gbbr requested review from a team and evan-bradley December 12, 2022 10:50
@runforesight
Copy link

runforesight bot commented Dec 12, 2022

Foresight Summary

    
Major Impacts

TestLoadInvalidConfig_NoScrapers ❌ failed 12 times in 12 runs (100% fail rate).
build-and-test-windows duration(4 seconds) has decreased 39 minutes 55 seconds compared to main branch avg(39 minutes 59 seconds).
View More Details

⭕  changelog workflow has finished in 3 seconds (7 minutes 34 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

⭕  build-and-test-windows workflow has finished in 4 seconds (39 minutes 53 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  tracegen workflow has finished in 1 minute 15 seconds (2 minutes 28 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  check-links workflow has finished in 1 minute 16 seconds (2 minutes 7 seconds less than main branch avg.) and finished at 13th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  prometheus-compliance-tests workflow has finished in 10 minutes 48 seconds and finished at 13th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  build-and-test workflow has finished in 43 minutes 25 seconds (17 minutes 57 seconds less than main branch avg.) and finished at 13th Dec, 2022. There are 6 test failures.


Job Failed Steps Tests
unittest-matrix (1.19, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) -     🔗  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces -     🔗  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics -     🔗  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) -     🔗  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) -     🔗  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) -     🔗  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) -     🔗  ✅ 2532  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) -     🔗  ✅ 2532  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) -     🔗  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) -     🔗  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) -     🔗  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) -     🔗  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) -     🔗  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) -     🔗  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
integration-tests -     🔗  ✅ 53  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
check-collector-module-version -     🔗  N/A See Details
lint-matrix (receiver-0) -     🔗  N/A See Details
lint-matrix (receiver-1) -     🔗  N/A See Details
lint-matrix (processor) -     🔗  N/A See Details
lint-matrix (exporter) -     🔗  N/A See Details
lint-matrix (extension) -     🔗  N/A See Details
lint-matrix (internal) -     🔗  N/A See Details
lint-matrix (other) -     🔗  N/A See Details
build-examples -     🔗  N/A See Details
check-codeowners -     🔗  N/A See Details
checks -     🔗  N/A See Details
unittest (1.19) -     🔗  N/A See Details
unittest (1.18) -     🔗  N/A See Details
lint -     🔗  N/A See Details
cross-compile (darwin, amd64) -     🔗  N/A See Details
cross-compile (darwin, arm64) -     🔗  N/A See Details
cross-compile (linux, 386) -     🔗  N/A See Details
cross-compile (linux, amd64) -     🔗  N/A See Details
cross-compile (linux, arm) -     🔗  N/A See Details
cross-compile (linux, arm64) -     🔗  N/A See Details
cross-compile (linux, ppc64le) -     🔗  N/A See Details
cross-compile (windows, 386) -     🔗  N/A See Details
cross-compile (windows, amd64) -     🔗  N/A See Details
build-package (deb) -     🔗  N/A See Details
build-package (rpm) -     🔗  N/A See Details
windows-msi -     🔗  N/A See Details
publish-check -     🔗  N/A See Details
publish-dev -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  load-tests workflow has finished in 16 minutes 41 seconds and finished at 13th Dec, 2022.


Job Failed Steps Tests
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

This change adds the processor described in open-telemetry#15689. It is the initial PR
containing the structure and implementation.
processor/datadogprocessor/README.md Outdated Show resolved Hide resolved
processor/datadogprocessor/README.md Show resolved Hide resolved
processor/datadogprocessor/agent.go Outdated Show resolved Hide resolved
processor/datadogprocessor/agent.go Show resolved Hide resolved
processor/datadogprocessor/config.go Outdated Show resolved Hide resolved
processor/datadogprocessor/go.mod Outdated Show resolved Hide resolved
Copy link
Member Author

@gbbr gbbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

processor/datadogprocessor/README.md Show resolved Hide resolved
processor/datadogprocessor/README.md Outdated Show resolved Hide resolved
processor/datadogprocessor/agent.go Outdated Show resolved Hide resolved
processor/datadogprocessor/agent.go Show resolved Hide resolved
processor/datadogprocessor/config.go Outdated Show resolved Hide resolved
@gbbr gbbr requested review from mx-psi and removed request for evan-bradley December 12, 2022 13:24
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

processor/datadogprocessor/README.md Show resolved Hide resolved
processor/datadogprocessor/processor.go Outdated Show resolved Hide resolved
processor/datadogprocessor/README.md Show resolved Hide resolved
@gbbr gbbr requested a review from mx-psi December 12, 2022 15:10
@gbbr
Copy link
Member Author

gbbr commented Dec 12, 2022

I hope I didn't miss anything...

@mx-psi mx-psi added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 12, 2022
@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2022

Skipping changelog, will add when we add to components

@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2022

Looks like there are some lint failures after bumping to v0.67.0, @gbbr can you have a look?

@gbbr
Copy link
Member Author

gbbr commented Dec 12, 2022

Oops! Should be ok now.

@mx-psi
Copy link
Member

mx-psi commented Dec 13, 2022

I think the only remaining issue to be addressed is to run make generate-gh-issue-templates and commit the changes so that the checks job passes.

@gbbr gbbr requested a review from mx-psi December 13, 2022 09:10
@mx-psi mx-psi merged commit a0e93c0 into open-telemetry:main Dec 13, 2022
@gbbr gbbr deleted the gbbr/processor-2-component branch December 13, 2022 12:00
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants