Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/datadogexporter: add support for metrics as APM Stats #16852

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

gbbr
Copy link
Member

@gbbr gbbr commented Dec 12, 2022

This change adds the APM Stats consumer support into the Datadog Exporter.

Required by #16853

@gbbr gbbr requested a review from a team December 12, 2022 10:36
@gbbr gbbr requested a review from mx-psi as a code owner December 12, 2022 10:36
@runforesight
Copy link

runforesight bot commented Dec 12, 2022

Foresight Summary

    
Major Impacts

TestConsumeLogsUnexpectedExporterType ❌ failed 6 times in 6 runs (100% fail rate).
TestConsumeTracesUnexpectedExporterType ❌ failed 6 times in 6 runs (100% fail rate).
TestLoadInvalidConfig_NoScrapers ❌ failed 6 times in 6 runs (100% fail rate).
build-and-test-windows duration(5 seconds) has decreased 39 minutes 41 seconds compared to main branch avg(39 minutes 46 seconds).
View More Details

⭕  build-and-test-windows workflow has finished in 5 seconds (39 minutes 26 seconds less than main branch avg.) and finished at 12th Dec, 2022.


Job Failed Steps Tests
windows-unittest-matrix -     🔗  N/A See Details
windows-unittest -     🔗  N/A See Details

✅  check-links workflow has finished in 3 minutes 46 seconds (⚠️ 54 seconds more than main branch avg.) and finished at 12th Dec, 2022.


Job Failed Steps Tests
changed files -     🔗  N/A See Details
check-links -     🔗  N/A See Details

✅  tracegen workflow has finished in 4 minutes 12 seconds (⚠️ 52 seconds more than main branch avg.) and finished at 12th Dec, 2022.


Job Failed Steps Tests
build-dev -     🔗  N/A See Details
publish-latest -     🔗  N/A See Details
publish-stable -     🔗  N/A See Details

✅  changelog workflow has finished in 5 minutes 20 seconds and finished at 12th Dec, 2022.


Job Failed Steps Tests
changelog -     🔗  N/A See Details

 build-and-test workflow has finished in 23 minutes 58 seconds (38 minutes 23 seconds less than main branch avg.) and finished at 12th Dec, 2022. There are 6 test failures.


Job Failed Steps Tests
unittest-matrix (1.19, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, internal) N/A  ✅ 592  ❌ 0  ⏭ 0    🔗 See Details
correctness-traces N/A  ✅ 17  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-0) N/A  ✅ 2532  ❌ 1  ⏭ 0    🔗 See Details
unittest-matrix (1.19, processor) N/A  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, processor) N/A  ✅ 1465  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, other) N/A  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-1) N/A  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, receiver-0) N/A  ✅ 2532  ❌ 1  ⏭ 0    🔗 See Details
integration-tests N/A  ✅ 53  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.18, exporter) N/A  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.18, extension) N/A  ✅ 528  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, exporter) N/A  ✅ 2237  ❌ 2  ⏭ 0    🔗 See Details
unittest-matrix (1.19, receiver-1) N/A  ✅ 1854  ❌ 0  ⏭ 0    🔗 See Details
unittest-matrix (1.19, other) N/A  ✅ 4363  ❌ 0  ⏭ 0    🔗 See Details
correctness-metrics N/A  ✅ 2  ❌ 0  ⏭ 0    🔗 See Details

✅  prometheus-compliance-tests workflow has finished in 7 minutes 7 seconds (1 minute 59 seconds less than main branch avg.) and finished at 12th Dec, 2022.


Job Failed Steps Tests
prometheus-compliance-tests -     🔗  ✅ 21  ❌ 0  ⏭ 0    🔗 See Details

✅  load-tests workflow has finished in 11 minutes 41 seconds (4 minutes 18 seconds less than main branch avg.) and finished at 12th Dec, 2022.


Job Failed Steps Tests
loadtest (TestMetric10kDPS|TestMetricsFromFile) -     🔗  ✅ 6  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceNoBackend10kSPS|TestTrace1kSPSWithAttrs) -     🔗  ✅ 8  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestMetricResourceProcessor|TestTrace10kSPS) -     🔗  ✅ 12  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceBallast1kSPSWithAttrs|TestTraceBallast1kSPSAddAttrs) -     🔗  ✅ 10  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestBallastMemory|TestLog10kDPS) -     🔗  ✅ 19  ❌ 0  ⏭ 0    🔗 See Details
setup-environment -     🔗  N/A See Details
loadtest (TestIdleMode) -     🔗  ✅ 1  ❌ 0  ⏭ 0    🔗 See Details
loadtest (TestTraceAttributesProcessor) -     🔗  ✅ 3  ❌ 0  ⏭ 0    🔗 See Details

🔎 See details on Foresight

*You can configure Foresight comments in your organization settings page.

@github-actions github-actions bot added the exporter/datadog Datadog components label Dec 12, 2022
@gbbr gbbr requested a review from dmitryax as a code owner December 12, 2022 11:04
@github-actions github-actions bot added cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command labels Dec 12, 2022
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left two non-blocking comments

exporter/datadogexporter/metrics_exporter.go Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2022

Should we add a changelog here, since this adds functionality visible by users? Presence/absence of this feature may be relevant on setups with multiple Collectors with different versions

This change adds the APM Stats consumer support into the Datadog
Exporter.
@gbbr
Copy link
Member Author

gbbr commented Dec 12, 2022

PTAL. The way I see things, this change is useless without the processor. If the processor is added, then that will be in the changelog, and it will signal that there is support for it, if that makes sense.

@mx-psi
Copy link
Member

mx-psi commented Dec 12, 2022

To make the situation I was referring to clearer, let's assume we release this on v0.67.0. Then the following setup will be broken:

graph LR
    subgraph Collector v0.67.0
        A[OTLP<br/> Receiver] --> B[Datadog <br/>Processor] --> C[OTLP<br/> Exporter]
    end

    subgraph Collector v0.60.0
        C --> D[OTLP<br/> Receiver] --> E[Datadog <br/>exporter]
    end
Loading

and it will be easier for users to know why if we have a changelog that indicates what is the first version of the exporter that had support for this, the same way you added a changelog note on the Datadog Agent.

@mx-psi mx-psi merged commit 135f02c into open-telemetry:main Dec 12, 2022
@gbbr gbbr deleted the gbbr/processor-1-exporter branch December 12, 2022 13:59
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/configschema configschema command cmd/otelcontribcol otelcontribcol command exporter/datadog Datadog components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants