Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mdatagen] Rename metadata.yaml attribute field value -> name_override #16561

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Dec 1, 2022

value is a confusing name for an optional field that is used to override the attribute name defined in the key

`value` is a confusing name for an optional field that is used to override the attribute name defined in the key
@dmitryax dmitryax merged commit c6977ca into open-telemetry:main Dec 1, 2022
@dmitryax dmitryax deleted the mdatagen-rename-attribute-value branch December 3, 2022 10:23
shalper2 pushed a commit to shalper2/opentelemetry-collector-contrib that referenced this pull request Dec 6, 2022
open-telemetry#16561)

`value` is a confusing name for an optional field that is used to override the attribute name defined in the key
@plantfansam plantfansam mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants