-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/k8sobjects] initial commit #14699
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit. Otherwise LGTM
According to current logic, it will dynamically find GroupVersion for the given resource, but it is possible that other Groups also have resources with the same name. It will create a conflict. For example, both I need to add an API Group config to specify the group in case of a conflict. |
I use |
@dmitryax for events, it is using the Maybe we can handle this error better. |
@dmitryax is there any pending action item for me? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing it. It's good as an initial version. Any further work can be done separately
It looks like this PR broke tests on main, even if it passed here. I opened #15663 to revert it; unless the solution is quick I think we should revert so that we can proceed with today's release |
Initial version of a receiver to collect(pull/watch) Kubernetes Objects
Description:
Adding a receiver to collect(pull/watch) Kubernetes Objects
Link to tracking Issue:
#14185
Testing:
Added unit tests with mocked dynamic client and discovery client
Documentation: