[receiver/jaegerreceiver] Remove jaeger remote sampling from receiver #14163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
changed the title
frzifus
changed the title
jpkrohling
reviewed
Sep 16, 2022
There was a problem hiding this comment.
The change type has to be "breaking". Perhaps note in the description the issue that started the deprecation?
@yuriolisa: this change will require an upgrade routine for the operator. Basically, use the new jaeger remote sampling extension instead of the remote sampling endpoint that was part of the jaeger receiver.
unreleased/remove_jaeger_remote_sampling_from_receiver_#6633.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
remove_jaeger_remote_sampling_from_receiver_#6633
branch
from
1ff162e
to
15fe181
Compare
jpkrohling
approved these changes
Sep 16, 2022
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
remove_jaeger_remote_sampling_from_receiver_#6633
branch
from
86d39d3
to
6ea7efc
Compare
pavolloffay
approved these changes
Sep 16, 2022
djaglowski
pushed a commit
to djaglowski/opentelemetry-collector-contrib
that referenced
this pull request
Sep 19, 2022
…open-telemetry#14163) Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
deleted the
remove_jaeger_remote_sampling_from_receiver_#6633
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Remove jaeger remote sampling from jaegerreceiver
Link to tracking Issue: #6633
Testing: adapt unittest
Documentation: