[processor/filter] prevent the matcher from panicking #14147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frzifus
force-pushed
the
processor-filter_prevent_panic
branch
from
3e7071d
to
9881479
Compare
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
frzifus
force-pushed
the
processor-filter_prevent_panic
branch
from
9881479
to
0e24066
Compare
|
Hi @boostchicken, could you have a look please? |
|
What do you think @open-telemetry/collector-contrib-approvers ? |
jpkrohling
approved these changes
Oct 4, 2022
|
LGTM, but perhaps the code owner still wants to review it? If there are no answers by the end of tomorrow, I'll merge this. |
|
Should we go ahead? :) cc @jpkrohling |
shalper2
pushed a commit
to shalper2/opentelemetry-collector-contrib
that referenced
this pull request
Dec 6, 2022
…#14147) * [processor/filter] prevent the matcher from panicking Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de> * [processor/filter] add changelog Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de> Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prevent the filterexpr matcher from panicking. Followed the approach from @GCHQDeveloper638 - #13573 (comment)
Link to tracking Issue: #13573
Testing:
Documentation: