Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metricstransformprocessor: Snap timestamps to the previous second/minute #9588

Closed
csmehta opened this issue Apr 29, 2022 · 7 comments
Closed

Comments

@csmehta
Copy link

csmehta commented Apr 29, 2022

Is your feature request related to a problem? Please describe.
I am trying to group by metrics coming from different workers to the collector.

    - include: app.counter.job.input-row
          action: update
          operations:
            - action: aggregate_labels
              aggregation_type: sum
              label_set: []

But for this to be effective timestamps have to match as well.

Describe the solution you'd like
Ability to snap timestamp to nearest second/minute based on config.

    - include: app.counter.job.input-row
          action: update
          operations:
            - action: update_timestamp
              round_to_nearest: 1m
            - action: aggregate_labels
              aggregation_type: sum
              label_set: []

Describe alternatives you've considered
None

Additional context
This will help reduce the outgoing metric volume, considering we don't require sub-second visibility into the metric.

@kamalmarhubi
Copy link
Contributor

@csmehta if you're willing to either use Honeycomb's build or build your own with the builder, take a look at https://github.com/honeycombio/opentelemetry-collector-configs/tree/main/timestampprocessor

@codeboten codeboten added the needs triage New item requiring triage label Sep 16, 2022
@nicolasgere
Copy link

Did you found a solution there?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Jan 3, 2023
@atoulme atoulme added processor/metricstransform Metrics Transform processor and removed needs triage New item requiring triage labels Mar 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Pinging code owners for processor/metricstransform: @dmitryax. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

dmitryax commented Mar 8, 2023

Given that this processor will be replaced with transform processor going forward, I don't think we should invest in any kind of time aggregation. Probably a better approach is to start with introducing timestamp trimming functionality to the transform processor.

@github-actions github-actions bot removed the Stale label May 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 26, 2023
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants