Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/memcached] Revisit metric types #6886

Closed
dmitryax opened this issue Dec 17, 2021 · 0 comments · Fixed by #6895
Closed

[receiver/memcached] Revisit metric types #6886

dmitryax opened this issue Dec 17, 2021 · 0 comments · Fixed by #6895
Assignees
@djaglowski
Labels
bug Something isn't working receiver/memcached

Comments

@dmitryax
Copy link
Member

The following metrics reported as double values but exposed as int stats by memcached:

  • threads memcached stat -> memcached.threads metric (Number of threads used by the memcached instance)
  • curr_items memcached stat -> memcached.current_items metric (Number of items currently stored in the cache)
@dmitryax dmitryax added the bug Something isn't working label Dec 17, 2021
@dmitryax dmitryax mentioned this issue Dec 17, 2021
Closed
@djaglowski djaglowski changed the title [receiver/memcached] - Revisit metric types [receiver/memcached] Revisit metric types Dec 17, 2021
@djaglowski djaglowski self-assigned this Dec 17, 2021
@djaglowski djaglowski mentioned this issue Dec 17, 2021
Merged
animetauren pushed a commit to animetauren/opentelemetry-collector-contrib that referenced this issue Apr 4, 2023
@moh-osman3
Instrument proctelemetry.ProcessMetrics (open-telemetry#6886)
297e391 
* Instrument proctelemetry.ProcessMetrics (open-telemetry#67)

* Instrument proctelemetry.ProcessMetrics

* add chloggen

* fix lint and remove unneeded context

* catch potential case where some metricValues are 0

* address review feedback

* rebase and remove unneeded registry

* only run assertMetrics for OC

* address review comments

* rebase and update featuregate function in use

* rebase and update to use new otel metrics api

* fix lint err

* address feedback

* newline

* use multierr for errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@djaglowski djaglowski

Labels
bug Something isn't working receiver/memcached
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[receiver/memcached] Fix some issues in metadata.yaml djaglowski/opentelemetry-collector-contrib
2 participants
@djaglowski @dmitryax