Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test - prometheusexporter.TestEndToEndSummarySupport #6228

Closed
djaglowski opened this issue Nov 10, 2021 · 6 comments
Closed

Flaky Test - prometheusexporter.TestEndToEndSummarySupport #6228

djaglowski opened this issue Nov 10, 2021 · 6 comments
Assignees
Labels
bug Something isn't working comp: exporter Exporter comp:prometheus Prometheus related issues flaky test a test is flaky

Comments

@djaglowski
Copy link
Member

djaglowski commented Nov 10, 2021

Seen here.

=== RUN   TestEndToEndSummarySupport
    end_to_end_test.go:182: Left-over unmatched Prometheus scrape content: "test_jvm_gc_collection_seconds_count{gc=\"G1 Old Generation\"} 9.223372036854776e+18 1636565705608test_jvm_info{vendor=\"Oracle Corporation\",version=\"9.0.4+11\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"CodeHeap 'non-nmethods'\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"CodeHeap 'non-profiled nmethods'\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"CodeHeap 'profiled nmethods'\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"Compressed Class Space\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"G1 Eden Space\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"G1 Old Gen\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"G1 Survivor Space\"} NaN 1636565705608test_jvm_memory_pool_bytes_used{pool=\"Metaspace\"} NaN 1636565705608test_scrape_samples_post_metric_relabeling 0 1636565705617test_scrape_samples_scraped 0 1636565705617test_scrape_series_added 0 1636565705617test_up 0 1636565705617"
--- FAIL: TestEndToEndSummarySupport (5.08s)

No code owner is currently assigned for this component.

@djaglowski djaglowski added the bug Something isn't working label Nov 10, 2021
@alolita alolita added comp: exporter Exporter comp:prometheus Prometheus related issues labels Nov 10, 2021
@PaurushGarg
Copy link
Member

@alolita please assign this issue to me. I would like to work on this one.

@mx-psi mx-psi added the flaky test a test is flaky label Nov 16, 2021
@jpkrohling
Copy link
Member

@jpkrohling
Copy link
Member

@PaurushGarg, do you have any progress to share?

@PaurushGarg
Copy link
Member

PaurushGarg commented Dec 8, 2021

@PaurushGarg, do you have any progress to share?

@jpkrohling I have raised a PR for this on open-o11y for approval by @Aneurysm9 before I raise it here. Link for OR: open-o11y#1026
As per my understanding, this is happening because intention of this test is to have HttpTest server respond (dropWizard) to atleast 8 requests -- but it only responds to first 8 requests because of the way select statement for waitForScrapes is configured. And if the last GET request by the Prometheus Receiver doesn't receive the response (dropWizard) from the HTTP test server, receiver would generate staleNaN (for first time no response is encountered). and that's why this test is flaky..

@dashpole
Copy link
Contributor

This is fixed

@dmitryax
Copy link
Member

dmitryax commented Mar 9, 2022

It seems to be failing again with another message: #8365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp: exporter Exporter comp:prometheus Prometheus related issues flaky test a test is flaky
Projects
None yet
Development

No branches or pull requests

8 participants