-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement merging of Resources with different schemas in resourcedetectionprocessor #4620
Comments
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
Depends on #5036 |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping |
This is waiting for OTEP 0161 and for schema processor implementation. |
Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
resourcedetectionprocessor modifies the Resources that pass through it by merging it with the Resources
it detected. This merging is valid when the schemas of the original Resource and the merged Resource
are the same, but it is generally speaking incorrect when the schemas are different.
Proposed OTEP 0161 defines how Resources of different schemas can be merged correctly by leveraging
schema conversion capabilities:
https://github.com/open-telemetry/oteps/blob/b2cb1558c6fa88535ef68f7a19df147a1b6fc162/text/0161-telemetry-schema-and-resource.md#resource-merge-logic
Once we have a code that implements schema conversion we can use it in resourcedetectionprocessor's
MergeSchemaURL/MergeResource functions.
The text was updated successfully, but these errors were encountered: