Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement merging of Resources with different schemas in resourcedetectionprocessor #4620

Open
tigrannajaryan opened this issue Aug 13, 2021 · 5 comments
Labels
never stale Issues marked with this label will be never staled and automatically removed processor/resourcedetection Resource detection processor

Comments

@tigrannajaryan
Copy link
Member

resourcedetectionprocessor modifies the Resources that pass through it by merging it with the Resources
it detected. This merging is valid when the schemas of the original Resource and the merged Resource
are the same, but it is generally speaking incorrect when the schemas are different.

Proposed OTEP 0161 defines how Resources of different schemas can be merged correctly by leveraging
schema conversion capabilities:
https://github.com/open-telemetry/oteps/blob/b2cb1558c6fa88535ef68f7a19df147a1b6fc162/text/0161-telemetry-schema-and-resource.md#resource-merge-logic

Once we have a code that implements schema conversion we can use it in resourcedetectionprocessor's
MergeSchemaURL/MergeResource functions.

@tigrannajaryan tigrannajaryan changed the title Implement merging of Resources with different schemas in resourcedetectionprocessor/internal/resourcedetection.go Implement merging of Resources with different schemas in resourcedetectionprocessor Aug 13, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 4, 2022
@tigrannajaryan
Copy link
Member Author

Depends on #5036

@github-actions github-actions bot removed the Stale label Mar 26, 2023
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label May 26, 2023
@tigrannajaryan tigrannajaryan added never stale Issues marked with this label will be never staled and automatically removed and removed Stale labels May 26, 2023
@tigrannajaryan
Copy link
Member Author

This is waiting for OTEP 0161 and for schema processor implementation.

@mx-psi mx-psi added the processor/resourcedetection Resource detection processor label Jan 10, 2024
Copy link
Contributor

Pinging code owners for processor/resourcedetection: @Aneurysm9 @dashpole. See Adding Labels via Comments if you do not have permissions to add labels yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never stale Issues marked with this label will be never staled and automatically removed processor/resourcedetection Resource detection processor
Projects
None yet
Development

No branches or pull requests

2 participants