Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/pdatatest] Support profiles signal comparison #36232

Open
odubajDT opened this issue Nov 6, 2024 · 4 comments · May be fixed by #36273
Open

[pkg/pdatatest] Support profiles signal comparison #36232

odubajDT opened this issue Nov 6, 2024 · 4 comments · May be fixed by #36273
Labels
data:profiles Profiles related issues enhancement New feature or request pkg/pdatatest

Comments

@odubajDT
Copy link
Contributor

odubajDT commented Nov 6, 2024 •
edited
Loading

Component(s)

pkg/pdatatest

Is your feature request related to a problem? Please describe.

With introduction of profiles signal, we should add the adequate functionality also for profiles signal comparison library for testing.

Describe the solution you'd like

Add CompareSignals function same as it's done for other signal types

Describe alternatives you've considered

No response

Additional context

No response
@odubajDT odubajDT added enhancement New feature or request needs triage New item requiring triage labels Nov 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 6, 2024

I will start working on this issue and open a PR soon

@odubajDT odubajDT changed the title [pkg/pdatatest] Improve package to support profile signal comparison [pkg/pdatatest] Improve package to support profiles signal comparison Nov 6, 2024
@odubajDT odubajDT changed the title [pkg/pdatatest] Improve package to support profiles signal comparison [pkg/pdatatest] Support profiles signal comparison Nov 6, 2024
@djaglowski djaglowski removed the needs triage New item requiring triage label Nov 7, 2024
@odubajDT
Copy link
Contributor Author

odubajDT commented Nov 8, 2024

@mx-psi

@odubajDT odubajDT linked a pull request Nov 8, 2024 that will close this issue
Draft
@github-actions github-actions bot mentioned this issue Nov 12, 2024
Open
@mx-psi
Copy link
Member

mx-psi commented Nov 12, 2024

Makes sense to me :)

@mx-psi mx-psi added the data:profiles Profiles related issues label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
data:profiles Profiles related issues enhancement New feature or request pkg/pdatatest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pkg/pdatatest] support Profiles signal comparison odubajDT/opentelemetry-collector-contrib
3 participants
@djaglowski @mx-psi @odubajDT