-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processor/attributes] Add support for profiles signal #35981
Comments
Pinging code owners for processor/attributes: @boostchicken. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Hi, if possible, I would like to look at this issue |
@odubajDT Sure, go ahead! Profiles implementation may be a bit more complex since there are multiple places where there can be attributes. Feel free to ping me once you have the PR so we can find the right reviewers |
After a brief investigation, there is a need to add support for profiles in Additionally, support in |
/label internal/filter |
Pinging code owners for internal/filter: @open-telemetry/collector-approvers. See Adding Labels via Comments if you do not have permissions to add labels yourself. |
I want to throw out the idea that we don't add profile support to any component listed in #18643 and instead rely on profiles support in the transform processor. |
I am okay with that, however there are changes coming to the profiles data model that may mean churn in the OTTL implementation. @dmathieu and the Profiling SIG can help inform what OTTL functions are 'safer' (in that we don't expect that part of the data model to change) |
Seeing the number of changes currently being made in the OTLP for profiles, I think we can assume there won't be any "safe" location. |
Then up to @TylerHelmuth to decide if they are willing to deal with the churn. We may also not do this and not do OTTL for now, focusing only on components that deal with the resource only/deal with the proto in an abstract way |
If the proto for profiles is churning, then pdata is churning, which means any attributes and OTTL will churn. It sounds like we should wait. |
I agree to wait until the currently planned changes are shipped, after which I hope the profo should stabilize a little bit. |
When we are ready to come back to this I do think we should only add support to the transformprocessor. |
Component(s)
processor/attributes
Describe the issue you're reporting
This processor would be useful for testing and validation of the experimental profiling signal.
As inspiration for how to add support this PR can be used: open-telemetry/opentelemetry-collector/pull/11071 (there is no processor with support as of the writing of this issue)
Example of configuration using profiles (needs
service.profilesSupport
feature gate to be enabled):The text was updated successfully, but these errors were encountered: