Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/httpcheck] Report certificate information #35968

Open
atoulme opened this issue Oct 23, 2024 · 5 comments
Open

[receiver/httpcheck] Report certificate information #35968

atoulme opened this issue Oct 23, 2024 · 5 comments
Labels
enhancement New feature or request receiver/httpcheck HTTP Check receiver

Comments

@atoulme
Copy link
Contributor

atoulme commented Oct 23, 2024

Component(s)

receiver/httpcheck

Is your feature request related to a problem? Please describe.

The httpcheckreceiver can be used to perform periodic checks of a HTTP endpoint.
The receiver can be enhanced to report certificate information as well.

Describe the solution you'd like

Ideally, the solution should match the metric and method used by the tlscheckreceiver. https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/tlscheckreceiver

Describe alternatives you've considered

No response

Additional context

No response

@atoulme atoulme added enhancement New feature or request needs triage New item requiring triage receiver/httpcheck HTTP Check receiver and removed needs triage New item requiring triage labels Oct 23, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for receiver/httpcheck: @codeboten. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@StephanSalas
Copy link

StephanSalas commented Oct 25, 2024

I think this could be very useful as both a conditional and optional set of metrics.

E.g. The metrics are only reported for "https" protocol, and only if the user turns it on.

I do wonder if we can approximately copy the metrics enumeration elastic has made:

  1. http_cert_status
  2. http_cert_cname
  3. http_cert_issuedby
  4. http_cert_validuntil
  5. http_cert_age
  6. http_cert_fingerprints

@atoulme
Copy link
Contributor Author

atoulme commented Oct 28, 2024

These are dimensions to metrics, looks like. My proposal is to match what tlscheck receiver offers.

@StephanSalas
Copy link

These are dimensions to metrics, looks like. My proposal is to match what tlscheck receiver offers.

Not a bad convention... I think a limited set of metric dimentions to start may be easier / more minimal.

I wouldn't mind taking a stab at this one... it is quite interesting that we have:

  1. TLSCheck
  2. HttpCheck

As separate components, when this proposal kind of combines the TLSCheck functionality (sort of) with HttpCheck. It seems to be like we could potentially re-use some of the TLSCheck code. I will contemplate some options there...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/httpcheck HTTP Check receiver
Projects
None yet
Development

No branches or pull requests

2 participants