Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UDP receivers using Jaeger agent code #35765

Open
yurishkuro opened this issue Oct 14, 2024 · 2 comments
Open

Remove UDP receivers using Jaeger agent code #35765

yurishkuro opened this issue Oct 14, 2024 · 2 comments
Labels
help wanted Extra attention is needed unmaintained Identifies issues/prs for unmaintained components

Comments

@yurishkuro
Copy link
Member

Component(s)

receiver/jaeger

Details

Jaeger will be removing jaeger-agent code (jaegertracing/jaeger#4739). It is currently being imported by jaegerreceiver. How do contrib maintainers want to handle that?

@yurishkuro yurishkuro added help wanted Extra attention is needed unmaintained Identifies issues/prs for unmaintained components labels Oct 14, 2024
@atoulme
Copy link
Contributor

atoulme commented Nov 9, 2024

Typically we would first deprecate the code, and make sure to have a warning whenever it executes on startup, and in a future release we would then remove it outright.

What exactly is deprecated? Can you please deprecate the jaeger code itself following Golang best practices so we get the deprecation lint errors on upgrade?

@yurishkuro
Copy link
Member Author

yurishkuro commented Nov 9, 2024

In jaeger itself we have a linter that will fail ci if it encounters the use of deprecated functions. So I'm not sure that is the best path. I think can log warnings to users who still use these components in their config, and then some time later remove the components.

What grace period does this repo give to users for deprecated components?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed unmaintained Identifies issues/prs for unmaintained components
Projects
None yet
Development

No branches or pull requests

2 participants