Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: Faro exporter #35319

Open
3 tasks done
mar4uk opened this issue Sep 20, 2024 · 4 comments
Open
3 tasks done

New component: Faro exporter #35319

mar4uk opened this issue Sep 20, 2024 · 4 comments
Labels
Sponsor Needed New component seeking sponsor

Comments

@mar4uk
Copy link
Contributor

mar4uk commented Sep 20, 2024

The purpose and use-cases of the new component

The purpose of this component would be to export telemetry to the Grafana Cloud Frontend Observability Collector

Example configuration for the component

exporters:
  faro:
    endpoint: https://faro-collector-example.grafana.net/collect/app-key-example

Telemetry data types supported

Logs
Traces

Is this a vendor-specific component?

  • This is a vendor-specific component
  • If this is a vendor-specific component, I am a member of the OpenTelemetry organization.
  • If this is a vendor-specific component, I am proposing to contribute and support it as a representative of the vendor.

Code Owner(s)

mar4uk, rlankfo

Sponsor (optional)

No response

Additional context

No response

@mar4uk mar4uk added needs triage New item requiring triage Sponsor Needed New component seeking sponsor labels Sep 20, 2024
@atoulme
Copy link
Contributor

atoulme commented Sep 25, 2024

Reviewed quickly during the SIG meeting on 9/24: this is not a vendor-specific component if it targets an open source solution in my opinion.
@jpkrohling would you please review?

@mar4uk
Copy link
Contributor Author

mar4uk commented Sep 25, 2024

Hey @atoulme! Thank you for reviewing! Faro exporter is a vendor-specific (Grafana) component because the target is the Faro collector whose code is not an open source

@atoulme atoulme removed the needs triage New item requiring triage label Oct 12, 2024
@atoulme
Copy link
Contributor

atoulme commented Oct 12, 2024

Understood. @mar4uk, we have some new rules where we try to limit vendor-specific to one per type (exporter, processor, receiver, connector). See https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#vendor-specific-components

This might mean this component would be called "grafanaexporter", exporting to Faro.

@mar4uk
Copy link
Contributor Author

mar4uk commented Oct 14, 2024

Thank you for clarifications! Got it. Currently, there are no grafana-specific exporters in the repo, which means rules are not violated. I will name it grafanaexporter as you proposed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsor Needed New component seeking sponsor
Projects
None yet
Development

No branches or pull requests

2 participants