-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Oracle Cloud with Resource Detection Processor #35091
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
This works for me. This isn't a "new component" exactly, since it is part of an existing one, but it would be helpful to still roughly follow the new component process: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#adding-new-components. I'll act as your sponsor, and will review PRs. Before we get started, it would be good to know:
|
Thanks @dashpole
I wrote this to explain that
|
It would likely be "oci", "oracle", or "oracle_cloud_infrastructure", based on naming of other detectors: https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-collector-contrib+%22type%3A+resourcedetectionprocessor%22&type=code We might want to stay away from OCI, as that is currently used for the open container initiative in the conventions: https://github.com/open-telemetry/semantic-conventions/blob/156daec14fe8ca12d3fd8c3fad9602e4f80493b2/model/registry/oci.yaml I would also encourage you to update the list of providers, platforms, etc in the conventions so we get constants we can use from the semconv package: https://github.com/open-telemetry/semantic-conventions/blob/156daec14fe8ca12d3fd8c3fad9602e4f80493b2/model/registry/cloud.yaml#L101. It doesn't need to block the initial release, but we should have those eventually. |
Thanks for the pointers. "oracle_cloud_infrastructure" makes sense. |
Cool, you will have a folder in https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor/internal. You should be able to follow https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md#vendor-specific-components, and open the "First PR". You won't need to do every part of that. Just look at other detectors if you aren't sure. |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
processor/resourcedetection
Is your feature request related to a problem? Please describe.
The Resource Detection Processor do not support Oracle's Cloud ("Oracle Cloud Infrastructure" or "OCI") yet.
Describe the solution you'd like
We propose to develop this processor to support detecting OCI compute node and (Oracle Kubernetes Engine) node resources.
OCI offers the Instance Metadata Service which works like the one from AWS.
We're from Oracle and happy to contribute to implement and maintain this feature.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: