Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/deltatocumulative]: investigate possible int overflows in internal/data/expo #34828

Open
sh0rez opened this issue Aug 23, 2024 · 5 comments
Labels

Comments

@sh0rez
Copy link
Member

sh0rez commented Aug 23, 2024

Component(s)

processor/deltatocumulative

What happened?

gosec linter started flagging possible integer overflow errors in recent versions:

deltatocumulativeprocessor/internal/data/expo/expotest/bins.go:45:25: G115: integer overflow conversion int -> int32 (gosec)
	buckets.SetOffset(int32(start - 3))
	                       ^
deltatocumulativeprocessor/internal/data/expo/expotest/bins.go:62:36: G115: integer overflow conversion int -> int32 (gosec)
			bs.SetOffset(bs.Offset() + int32(idx))
			                                ^
deltatocumulativeprocessor/internal/data/expo/expotest/histogram.go:57:19: G115: integer overflow conversion int -> int32 (gosec)
	dp.SetScale(int32(hist.Scale))

while these are not necessarily real security implications, we must investigate

Collector version

bddc8c2

@sh0rez sh0rez added bug Something isn't working needs triage New item requiring triage labels Aug 23, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@sh0rez
Copy link
Member Author

sh0rez commented Aug 23, 2024

/label processor/deltatocumulative -needs-triage

Copy link
Contributor

Pinging code owners for processor/deltatocumulative: @sh0rez @RichieSams @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot removed the needs triage New item requiring triage label Aug 23, 2024
@odubajDT
Copy link
Contributor

I was not able to reproduce the problem locally with the current state of main branch and with gosec. Are you able to reproduce it with gosec ./... or did you use some special parameters?

Thanks!

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants