Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests] gotestsum: Device or resource busy #34691

Closed
pjanotti opened this issue Aug 14, 2024 · 2 comments · Fixed by #35192
Closed

[tests] gotestsum: Device or resource busy #34691

pjanotti opened this issue Aug 14, 2024 · 2 comments · Fixed by #35192
Labels
ci-cd CI, CD, testing, build issues flaky test a test is flaky needs triage New item requiring triage os:windows

Comments

@pjanotti
Copy link
Contributor

Component(s)

No response

Describe the issue you're reporting

I've seen this at least twice, it seems to be happening only on Windows.

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10187830131/job/28182730990?pr=34358#step:6:21

/usr/bin/sh: line 1: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum: Device or resource busy
make[2]: *** [../../Makefile.Common:126: test] Error 126
make[1]: *** [Makefile:179: processor/cumulativetodeltaprocessor] Error 2
make[1]: *** Waiting for unfinished jobs....
D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 600s -parallel 4 --tags=""

https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10393361946/job/28780698354?pr=34656#step:6:21

/usr/bin/sh: line 1: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum: Device or resource busy
make[2]: *** [../../Makefile.Common:126: test] Error 126
make[1]: *** [Makefile:179: exporter/prometheusremotewriteexporter] Error 2
make[1]: *** Waiting for unfinished jobs....
D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 600s -parallel 4 --tags=""

/label os:windows
@pjanotti pjanotti added the needs triage New item requiring triage label Aug 14, 2024
@pjanotti pjanotti mentioned this issue Aug 14, 2024
Merged
@crobert-1 crobert-1 added flaky test a test is flaky ci-cd CI, CD, testing, build issues os:windows labels Aug 14, 2024
@github-actions github-actions bot mentioned this issue Aug 20, 2024
Closed
@pjanotti
Copy link
Contributor Author

+1 https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10495420150/job/29073819109?pr=34793#step:6:21

/usr/bin/sh: line 1: D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum: Device or resource busy
make[2]: *** [../../Makefile.Common:126: test] Error 126
make[1]: *** [Makefile:179: processor/probabilisticsamplerprocessor] Error 2
make[1]: *** Waiting for unfinished jobs....
D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib/.tools/gotestsum --rerun-fails=1 --packages="./..." -- -race -timeout 600s -parallel 4 --tags=""
∅  internal/metadata
✓  . (1.337s)

DONE 19 tests in 11.575s
make[1]: Leaving directory 'D:/a/opentelemetry-collector-contrib/opentelemetry-collector-contrib'
make: *** [Makefile:1[27](https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10495420150/job/29073819109?pr=34793#step:6:28): gotest] Error 2
Error: Process completed with exit code 1.

This was referenced Aug 27, 2024
Closed
Closed
@github-actions github-actions bot mentioned this issue Sep 10, 2024
Closed
@pjanotti
Copy link
Contributor Author

I'm not tracking each occurrence but a cursory look at Windows CI failures show this one at, or near, the top of the failures. I can't repro it locally and happens with different components, we may have to change gotestsum settings to try to get some more information that can help get to the bottom of it.

This was referenced Sep 14, 2024
Closed
Merged
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@pjanotti @jriguera
[chore] Fix "Device or resource busy" error on Windows CI (open-telem…
4a47dcb 
…etry#35192)

**Description:**
The error "Device or resource busy" happens intermittently when running
the `build-and-test-windows` workflow on CI. Examining a few instances
of the error it becomes clear that the concurrent run of component tests
trigger concurrent builds of `gotestsum`. This can cause one of the runs
to clash with the other and fail to build the `gotestsum` target.

The fix is to add a explicit step to build `gotestsum` in the CI
workflow. This way the local dev modus operandi is not altered (they can
still rely on `make test` to build any tool necessary for the test). If
any other tools are added to the `test` target they should also be added
to the workflow on Windows.

**Link to tracking Issue:**
Fix open-telemetry#34691

**Testing:**
Validated on repository fork.

**Documentation:**
N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci-cd CI, CD, testing, build issues flaky test a test is flaky needs triage New item requiring triage os:windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chore] Fix "Device or resource busy" error on Windows CI pjanotti/opentelemetry-service-contrib
2 participants
@pjanotti @crobert-1