Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/logdeduplication] Review processor shutdown behaviour #34478

Closed
MikeGoldsmith opened this issue Aug 7, 2024 · 5 comments
Closed

[processor/logdeduplication] Review processor shutdown behaviour #34478

MikeGoldsmith opened this issue Aug 7, 2024 · 5 comments
Assignees
@MikeGoldsmith
Labels
processor/logdedup

Comments

@MikeGoldsmith
Copy link
Member

MikeGoldsmith commented Aug 7, 2024 •
edited
Loading

This is a tracking issue for reviewing the shutdown behaviour in the new logdeduplication processor.

          Is all of this extraneous? Create a local done channel, listen for it to close, but defer closing it?

The only thing somewhat useful this might be doing is returning ctx.Err() in the case where the passed in context is canceled while we're shutting down. I'm not convinced that's useful though and not aware of any other cases where we do that in Shutdown.

Originally posted by @djaglowski in #34465 (comment)
@MikeGoldsmith MikeGoldsmith mentioned this issue Aug 7, 2024
Merged
@codeboten
Copy link
Contributor

Thanks for volunteering to take this on @MikeGoldsmith

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Pinging code owners for processor/logdeduplication: @BinaryFissionGames @MikeGoldsmith @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@MikeGoldsmith MikeGoldsmith mentioned this issue Aug 9, 2024
Merged
djaglowski pushed a commit that referenced this issue Aug 9, 2024
@MikeGoldsmith
fix(processor/logdedup): Update shutdown behaviour (#34563)
db6629b 
**Description:** <Describe what has changed.>
Simplifies the processor shutdown behaviour by removing the unnecessary
done channel.

**Link to tracking Issue:**

- #34478 

**Testing:**

Updated unit test verifying shutdown behaviour.

**Documentation:**

N/A
@MikeGoldsmith
Copy link
Member Author

Fixed in #34563

@github-actions GitHub Actions
Copy link
Contributor

Pinging code owners for processor/logdedup: @BinaryFissionGames @MikeGoldsmith @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Sorry for the ping, I'm updating labels to the correct name of the processor to properly show up in queries for this component.

@github-actions github-actions bot mentioned this issue Aug 13, 2024
Closed
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this issue Sep 12, 2024
@MikeGoldsmith @f7o
fix(processor/logdedup): Update shutdown behaviour (open-telemetry#34563
ba40e13 
)

**Description:** <Describe what has changed.>
Simplifies the processor shutdown behaviour by removing the unnecessary
done channel.

**Link to tracking Issue:**

- open-telemetry#34478 

**Testing:**

Updated unit test verifying shutdown behaviour.

**Documentation:**

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeGoldsmith MikeGoldsmith

Labels
processor/logdedup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@codeboten @MikeGoldsmith @crobert-1