Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Kafka exporter to select topic from context #34432

Closed
tylerbenson opened this issue Aug 6, 2024 · 1 comment · Fixed by #34503
Closed

Allow Kafka exporter to select topic from context #34432

tylerbenson opened this issue Aug 6, 2024 · 1 comment · Fixed by #34503
Labels
enhancement New feature or request exporter/kafka needs triage New item requiring triage

Comments

@tylerbenson
Copy link
Member

Component(s)

exporter/kafka

Is your feature request related to a problem? Please describe.

The kafka exporter currently allows exporting to a fixed topic or a topic from an attribute in the data.
When using an attribute, if the topic name isn't already in the data for some reason, the topic name inherently pollutes the data.

Describe the solution you'd like

I would like to be able to pull the topic name from the context. This would allow prior components in the pipeline to define/customize the topic name without modifying the data being exported.

Describe alternatives you've considered

No response

Additional context

No response
@tylerbenson tylerbenson added enhancement New feature or request needs triage New item requiring triage labels Aug 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 6, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@tylerbenson tylerbenson mentioned this issue Aug 7, 2024
Merged
This was referenced Aug 13, 2024
Closed
Closed
This was referenced Aug 27, 2024
Closed
Closed
This was referenced Sep 10, 2024
Closed
Closed
@mx-psi mx-psi closed this as completed in c1e2df6 Sep 17, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this issue Oct 4, 2024
@tylerbenson @mx-psi
@MovieStoreGuy @jriguera
[kafka] Add option to supply destination topic through context (open-…
0e8ebef 
…telemetry#34503)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

Add option to get destination topic from context. This allows for
upstream connectors to control the destination without polluting the
data being written.


**Link to tracking Issue:** <Issue number if applicable>
Fixes open-telemetry#34432

**Testing:** <Describe what testing was performed and which tests were
added.>
Added unit tests.

**Documentation:** <Describe the documentation added.>
Updated the component readme with the added setting.

---------

Co-authored-by: Pablo Baeyens <pablo.baeyens@datadoghq.com>
Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request exporter/kafka needs triage New item requiring triage
Projects
None yet
Milestone
No milestone
1 participant
@tylerbenson