Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-otel is blocked on ambiguous import #33954

Closed
codeboten opened this issue Jul 8, 2024 · 2 comments · Fixed by #33977
Closed

update-otel is blocked on ambiguous import #33954

codeboten opened this issue Jul 8, 2024 · 2 comments · Fixed by #33977
Labels
release:blocker The issue must be resolved before cutting the next release

Comments

@codeboten
Copy link
Contributor

Component(s)

No response

Describe the issue you're reporting

Trying to update core to latest returns the following error:

go: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscloudwatchmetricsreceiver tested by
        github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscloudwatchmetricsreceiver.test imports
        go.opentelemetry.io/collector/confmap/confmaptest imports
        go.opentelemetry.io/collector/confmap imports
        go.opentelemetry.io/collector/internal/featuregates: ambiguous import: found package go.opentelemetry.io/collector/internal/featuregates in multiple modules:
        go.opentelemetry.io/collector v0.104.0 (~/1.22.3/packages/pkg/mod/go.opentelemetry.io/collector@v0.104.0/internal/featuregates)
        go.opentelemetry.io/collector/internal/featuregates v0.0.0-20240705161705-b127da089038 (~/1.22.3/packages/pkg/mod/go.opentelemetry.io/collector/internal/featuregates@v0.0.0-20240705161705-b127da089038)
@codeboten codeboten added the needs triage New item requiring triage label Jul 8, 2024
@codeboten
Copy link
Contributor Author

@mx-psi looks like this may require us to revert the change to make featuregates its own module, as far as i can tell, this happens because there's still modules that import the released version of go.opentelemetry.io/collector

@codeboten codeboten added release:blocker The issue must be resolved before cutting the next release and removed needs triage New item requiring triage labels Jul 8, 2024
@mx-psi
Copy link
Member

mx-psi commented Jul 9, 2024

I fixed this manually after running make update-otel by doing

make for-all CMD="go mod edit -require=go.opentelemetry.io/collector/internal/featuregates@v0.0.0-20240705161705-b127da089038 "
make gotidy

and it looks like it worked. PTAL at #33977! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants