Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module github.com/prometheus/prometheus to v0.53.0 causes test failures #33889

Closed
codeboten opened this issue Jul 3, 2024 · 3 comments
Labels
dependencies Pull requests that update a dependency file receiver/prometheus Prometheus receiver

Comments

@codeboten
Copy link
Contributor

Component(s)

receiver/prometheus

Describe the issue you're reporting

The upgrade causes the following test failures:


=== Failed
=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off/target1/target1 (0.00s)
    metrics_receiver_helper_test.go:446: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:446
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:398
        	Error:      	Should be true
        	Test:       	TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off/target1/target1
        	Messages:   	expected metric 'test_mixed_histogram' is not present

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off/target1 (0.00s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_off (6.51s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on/target1/target1 (0.00s)
    metrics_receiver_helper_test.go:446: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:446
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:398
        	Error:      	Should be true
        	Test:       	TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on/target1/target1
        	Messages:   	expected metric 'test_native_histogram' is not present

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on/target1 (0.00s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf/feature_enabled_scrape_classic_on (6.51s)

=== FAIL: . TestNativeVsClassicHistogramScrapeViaProtobuf (26.04s)

=== FAIL: . TestStaleExponentialHistogram/target1/target11 (0.00s)
    metrics_receiver_helper_test.go:446: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:446
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:398
        	Error:      	Should be true
        	Test:       	TestStaleExponentialHistogram/target1/target11
        	Messages:   	expected metric 'test_native_histogram' is not present

=== FAIL: . TestStaleExponentialHistogram/target1 (0.00s)

=== FAIL: . TestStaleExponentialHistogram (7.51s)

=== FAIL: . TestFloatCounterHistogram/target1 (0.00s)
    metrics_receiver_helper_test.go:313: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:313
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:253
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:702
        	Error:      	Not equal: 
        	            	expected: 0
=== FAIL: . TestStaleExponentialHistogram (re-run 1) (7.51s)

=== FAIL: . TestFloatCounterHistogram/target1 (re-run 1) (0.00s)
    metrics_receiver_helper_test.go:313: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:313
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:253
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:702
        	Error:      	Not equal: 
        	            	expected: 0
        	            	actual  : 1
        	Test:       	TestFloatCounterHistogram/target1
    metrics_receiver_helper_test.go:205: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:205
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_protobuf_test.go:600
        	            				/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver/metrics_receiver_helper_test.go:704
        	Error:      	"1" is not less than or equal to "0"
        	Test:       	TestFloatCounterHistogram/target1
        	Messages:   	want at least 1 valid scrapes, but got 0

=== FAIL: . TestFloatCounterHistogram (re-run 1) (6.52s)
@codeboten codeboten added the dependencies Pull requests that update a dependency file label Jul 3, 2024
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Jul 3, 2024
Copy link
Contributor

github-actions bot commented Jul 3, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@codeboten
Copy link
Contributor Author

Looks like a change in the prom library #33890

@dashpole
Copy link
Contributor

dashpole commented Jul 8, 2024

thanks for fixing @codeboten!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file receiver/prometheus Prometheus receiver
Projects
None yet
Development

No branches or pull requests

2 participants