Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New component: container processor #33822

Open
3 tasks
h0cheung opened this issue Jul 1, 2024 · 8 comments
Open
3 tasks

New component: container processor #33822

h0cheung opened this issue Jul 1, 2024 · 8 comments
Labels
Sponsor Needed New component seeking sponsor

Comments

@h0cheung
Copy link
Contributor

h0cheung commented Jul 1, 2024

The purpose and use-cases of the new component

There is now a k8sattributes processor' that associates data with k8s metadata. But not for normal containers. So I would like to add such a component. The k8sattributes processor' could perhaps also be maintained as part of this component.

#18920 made a similar request but was eventually closed due to lack of response

Example configuration for the component

similar to k8sattributes processor, with some fields for accessing container APIs:

docker_endpoint: unix:///var/run/docker.sock

Telemetry data types supported

traces, metrics, logs

Is this a vendor-specific component?

  • This is a vendor-specific component
  • If this is a vendor-specific component, I am a member of the OpenTelemetry organization.
  • If this is a vendor-specific component, I am proposing to contribute and support it as a representative of the vendor.

Code Owner(s)

No response

Sponsor (optional)

No response

Additional context

No response

@h0cheung h0cheung added needs triage New item requiring triage Sponsor Needed New component seeking sponsor labels Jul 1, 2024
@atoulme
Copy link
Contributor

atoulme commented Jul 6, 2024

Is the resourcedetectionprocessor not good for this? What would this processor set?

@h0cheung
Copy link
Contributor Author

h0cheung commented Jul 8, 2024

Is the resourcedetectionprocessor not good for this? What would this processor set?

metadata of docker container, including name, id, labels, etc.

@atoulme
Copy link
Contributor

atoulme commented Jul 8, 2024

@h0cheung
Copy link
Contributor Author

h0cheung commented Jul 8, 2024

Maybe worth adding to it: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/processor/resourcedetectionprocessor#docker-metadata

Those metadata could only be got from Docker API. Maybe it's better to use something similar to k8sattributes processor, than to mount the API into containers.

@atoulme
Copy link
Contributor

atoulme commented Jul 10, 2024

Sorry, I don't understand. The k8sattributes processor makes requests to the kubernetes API server. The docker resourcedetectionprocessor makes requests to the docker API endpoint. Are you trying to use the kubernetes API server to get container information?

@h0cheung
Copy link
Contributor Author

h0cheung commented Jul 10, 2024

Sorry, I don't understand. The k8sattributes processor makes requests to the kubernetes API server. The docker resourcedetectionprocessor makes requests to the docker API endpoint. Are you trying to use the kubernetes API server to get container information?

It uses Docker API. But the resourcedetection processor runs inside a container, which is similar to a sidecar in k8s, and it could only detect the hostname. This processor should run on the host, or a node-level container which is similar to daemonset in k8s. It will receive datas from in-container agents and associate them with all Docker metadata.

@atoulme
Copy link
Contributor

atoulme commented Jul 12, 2024

Is the difference that you only get the hostname right now?

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsor Needed New component seeking sponsor
Projects
None yet
Development

No branches or pull requests

2 participants