Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis receiver should add hostname to output metrics to filter #33708

Closed
nsteinmetz opened this issue Jun 21, 2024 · 2 comments
Closed

redis receiver should add hostname to output metrics to filter #33708

nsteinmetz opened this issue Jun 21, 2024 · 2 comments
Labels
bug Something isn't working needs triage New item requiring triage receiver/redis Redis related issues

Comments

@nsteinmetz
Copy link

Component(s)

receiver/redis

What happened?

Description

It seems that when using otelcol-contrib on different redis instances, then as there is no hostname to split views, there is only a global aggregated view when I see data on uptrace side.

Steps to Reproduce

Launch 2 instances of redis with otelcol-contrib defined on it

Expected Result

Being able to filter by hostname

Actual Result

No filter per hostname

Collector version

0.103.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@nsteinmetz nsteinmetz added bug Something isn't working needs triage New item requiring triage labels Jun 21, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the receiver/redis Redis related issues label Jun 21, 2024
@nsteinmetz
Copy link
Author

Ok found how to do it, just add the resourcedetection processor and add it in the pipeline configuration

  processors:
    resourcedetection:
      detectors: [env, system]
[...]
  service:
    pipelines:
      traces:
        receivers: [otlp]
        processors: [batch]
        exporters: [otlp/uptrace, debug]
      metrics:
        receivers: [otlp, redis]
        processors: [cumulativetodelta, batch, resourcedetection]
        exporters: [otlp/uptrace, debug]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage receiver/redis Redis related issues
Projects
None yet
Development

No branches or pull requests

1 participant